Consider running Bazel sample with Bazelisk about junit5-samples HOT 10 CLOSED

Ah, that's what you meant... ;-)

Sounds like a good idea! Would you be interested in submitting a PR?

from junit5-samples.

Thanks for looking into it! Since this issue is not time critical, I think we should wait for the bug fix to be officially released.

from junit5-samples.

I've renamed the issue after I realised that my phone incorrectly autocorrected "running" to "evening". ;)

from junit5-samples.

Sure, I'd be very interested! I probably won't be free until this weekend, but if you're happy to wait then I'll gladly give this a shot.

from junit5-samples.

Sure, sounds good! I've assigned you for the time being.

from junit5-samples.

Cheers @marcphilipp!

I started working on this today, but I quickly noticed that Bazelisk has a bug which I managed to fix locally on my machine and which I'm thinking of raising an issue or PR for soon.

Would you be happy for me to submit a PR to junit5-samples with my locally-fixed Bazelisk, or would you prefer that we wait until my fix is merged in?

from junit5-samples.

Cool, okay!

So far, my currently unpublished solution depends on Python being installed to get Bazelisk running. I did do some coding investigation to use Jython from within the build-all-samples.jsh, but it was a bit too complicated for me to fully suss out earlier this evening.

@marcphilipp Do you have a preference as to whether Python should be pre-installed or not? And if it's too much for me to figure out how to use Jython or a similar solution, what would your thoughts be?

from junit5-samples.

Oh, I should also say that my Bazelisk bug fix has been merged in, so that's out of the way now. :)

from junit5-samples.

I think it's okay to require Python since it's a requirement of Bazelisk. We can worry about making it better later, if need be.

from junit5-samples.

Great, sounds good to me @marcphilipp! I intend to submit a PR later tonight or tomorrow.

from junit5-samples.