Git Product home page Git Product logo

depthkit.js's Introduction

depthkit.js's People

Contributors

avnerus avatar juniorxsound avatar shirinstar avatar tim-depthkit avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

depthkit.js's Issues

character.depthkit.play() doent work sometimes on safari mobile ios

in my app it plays fine on desktop, on mobile (ios safari) i get this error over and over again.

Unhandled Promise Rejection: NotAllowedError: The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.
(anonymous function)
rejectPromise
play
value β€” depthkit.min.js:2:9573
(anonymous function) β€” main.js:620
update β€” main.js:300
animate β€” main.js:321
value β€” depthkit.min.js:2:9573

I do have it so the the user must tap the screen to start the whole experience, but the play itself is triggered by something else that happens after the user taps the screen. I suspect it might be because its not directly inside a user gesture? I say this because this toy project works fine: https://depthkit.glitch.me

this is whats supposed to happen: https://www.youtube.com/watch?v=_pZPpvudI7I&feature=youtu.be

This is my project: https://glitch.com/~ht94 you dont need to go through the experience just know its like the video except the character doesnt play. Posting it here incase you wanted to see the code (sorry i need to comment it)

how I got that video in the first place is that it used to work but i made some changes, i have been trying to pinpoint them to the exact moment it broken but its been taking hours, I thought id post this, keep looking and update when i find it, incase you have a suggestion for a quick fix... thank you!!

edit: I am not sure why it was working before I couldnt find any change in the code that caused it to break, I am sure it is there somewhere & there is a logical explanation but for now i cant spend any more time looking.

Plugin refactor RFC

It's been a moment since this plugin was last maintained and quite a lot has changed so wanted to collect some thoughts on potential future improvements.

  • New build system (perhaps Vite) to produce an ES module and externalizing three.js
  • Typescript
  • Build plugin in Github action on commit to avoid having to checkin built plugin file (i.e ./build/depthkit.js)
  • Deploy npm package via Github action on tag
  • Add support for new Depthkit metadata structure (i.e #24)
  • Better examples for WebXR API usage

Metadata parsing problem

The metadata that gets exported from depthkit app (without refinement workflow), does not match the format that this library expects, therefore clips cannot be loaded. Example:

{ "_versionMajor" : "0", "_versionMinor" : "1", "depthFocalLength" : { "x" : 505.453, "y" : 505.598 }, "depthImageSize" : { "x" : 640, "y" : 576 }, "depthPrincipalPoint" : { "x" : 321.734, "y" : 334.185 }, "farClip" : 8.192, "format" : "perpixel", "nearClip": 0.25, "clipEpsilon" : 0.000629564 }
Are the rest of the parameters not necessary? Why are they not exported in current depthkit version?

Add mesh relighting by scene lights

I have started implementing the ability to relight the mesh under lighting branch, does it make sense? is someone actually interested in being able to have the scene lights affect the mesh?

Add WebAR examples

I think it would make sense to add one or two WebAR examples, is someone interested in helping with this?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.