Git Product home page Git Product logo

Comments (19)

junegunn avatar junegunn commented on May 13, 2024

Thanks for the report, but I couldn't reproduce the problem. (I just installed oh-my-zsh, without any customization)

fzf-tmux-zsh

Could you check if it works on bash?

from fzf.

legendre6891 avatar legendre6891 commented on May 13, 2024

Thanks for the reply. Unfortunately, it does not work on bash either (same effect).

I tried again on zsh, this time holding control-T down. I see that a split is indeed created, with the content "zsh:4: command not found: fzf". It flashes for a second then the split closes.

I am on linux, if this helps.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Confirmed, reproducible on Linux. I'll come up with a fix today. Thanks.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Please update and rerun install script, and let me know if it still doesn't work.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

It should be fixed now, but I think there's more room for improvement, so I'm gonna leave this open until I feel confident about the implementation.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Finally looks good to me. Let me know if you have any problem.

from fzf.

dm avatar dm commented on May 13, 2024

You're definitely fast! 👍

from fzf.

junegunn avatar junegunn commented on May 13, 2024

@dm Thanks! But I should've done some more testing before releasing the code. 😌 Sorry for the confusion!

from fzf.

legendre6891 avatar legendre6891 commented on May 13, 2024

Works great! Thanks a lot 👍.

from fzf.

mclearc avatar mclearc commented on May 13, 2024

I'm seeing this issue with tmux 2.0, on OS X Yosemite, zsh 5.0.8, and the most recent update to fzf. When I export FZF_TMUX=0 things work. And fzf works normally outside of tmux.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

@mclearc This issue is very old and probably not related to the problem you're having. Please file a new one if you think it's a bug of fzf.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

@mclearc FYI, I can't reproduce the problem with Yosemite + zsh 5.0.8 + tmux 2.0.

from fzf.

mclearc avatar mclearc commented on May 13, 2024

Thanks. Since the screen flashes open and closed so quickly I can't tell what else might be the problem. Will open a new bug report if I get any new info.

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Hmm, it looks like fzf-tmux script is not working correctly on your env.

from fzf.

mclearc avatar mclearc commented on May 13, 2024

Exactly. I can run fzf but not fzf-tmux. Any ideas as to what might be the cause? Thanks too for your impressively quick responses!

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Inject a little sleep to the line 126 of fzf-tmux script like follows, so you can see what was the problem.

    split-window $opt "cd $(printf %q "$PWD");$envs bash $argsf; sleep 5" $swap

from fzf.

mclearc avatar mclearc commented on May 13, 2024

Thanks for that. This is what I get when I sleep the line:

fatal error: unexpected signal during runtime execution                                                                                                                       [42/42]
[signal 0xb code=0x1 addr=0x304 pc=0x7fff8bf99aad]

runtime stack:
runtime.gothrow(0x41b2d70, 0x2a)
        /usr/local/Cellar/go/1.4.2/libexec/src/runtime/panic.go:503 +0x8e
runtime.sigpanic()
        /usr/local/Cellar/go/1.4.2/libexec/src/runtime/sigpanic_unix.go:14 +0x5e

goroutine 8 [syscall, locked to thread]:
runtime.cgocall_errno(0x4001850, 0xc208057930, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/runtime/cgocall.go:130 +0xf5 fp=0xc208057910 sp=0xc2080578e8
github.com/junegunn/fzf/src/curses._Cfunc_noecho(0x0)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/curses/:122 +0x4b fp=0xc208057930 sp=0xc208057910
github.com/junegunn/fzf/src/curses.Init(0xc20801e2a0, 0xc208020100)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/curses/curses.go:265 +0x175 fp=0xc2080579d8 sp=0xc208057930
github.com/junegunn/fzf/src.func·022()
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/terminal.go:219 +0x46 fp=0xc2080579f0 sp=0xc2080579d8
github.com/junegunn/fzf/src.(*Terminal).Loop(0xc208076000)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/terminal.go:704 +0x143 fp=0xc208057fd8 sp=0xc2080579f0
runtime.goexit()
        /usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1 fp=0xc208057fe0 sp=0xc208057fd8
created by github.com/junegunn/fzf/src.Run
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/core.go:189 +0xaf8

goroutine 1 [semacquire]:
sync.(*Cond).Wait(0xc20802a040)
        /usr/local/Cellar/go/1.4.2/libexec/src/sync/cond.go:62 +0x9e
github.com/junegunn/fzf/src/util.(*EventBox).Wait(0xc20801e000, 0xc208050f38)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/util/eventbox.go:32 +0xaf
github.com/junegunn/fzf/src.Run(0xc208056000)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/core.go:259 +0xc74
main.main()
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/fzf/main.go:6 +0x2c

goroutine 5 [syscall]:
os/signal.loop()
        /usr/local/Cellar/go/1.4.2/libexec/src/os/signal/signal_unix.go:21 +0x1f
created by os/signal.init·1
        /usr/local/Cellar/go/1.4.2/libexec/src/os/signal/signal_unix.go:27 +0x35

goroutine 6 [syscall]:                                                                                                                                                        [21/62]
syscall.Syscall(0x3, 0x3, 0xc20800f000, 0x1000, 0xc20801e5e0, 0x4123060, 0x1)
        /usr/local/Cellar/go/1.4.2/libexec/src/syscall/asm_darwin_amd64.s:20 +0x5
syscall.read(0x3, 0xc20800f000, 0x1000, 0x1000, 0xc20803a840, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/syscall/zsyscall_darwin_amd64.go:970 +0x6e
syscall.Read(0x3, 0xc20800f000, 0x1000, 0x1000, 0x40307bc, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/syscall/syscall_unix.go:136 +0x58
os.(*File).read(0xc2080ae000, 0xc20800f000, 0x1000, 0x1000, 0xc20804cc50, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/os/file_unix.go:191 +0x86
os.(*File).Read(0xc2080ae000, 0xc20800f000, 0x1000, 0x1000, 0x60, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/os/file.go:95 +0x91
bufio.(*Reader).fill(0xc20802e1e0)
        /usr/local/Cellar/go/1.4.2/libexec/src/bufio/bufio.go:97 +0x1ce
bufio.(*Reader).ReadSlice(0xc20802e1e0, 0x100a, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/bufio/bufio.go:295 +0x257
bufio.(*Reader).ReadBytes(0xc20802e1e0, 0xa, 0x0, 0x0, 0x0, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/bufio/bufio.go:374 +0xd2
bufio.(*Reader).ReadString(0xc20802e1e0, 0xc2080ae00a, 0x0, 0x0, 0x0, 0x0)
        /usr/local/Cellar/go/1.4.2/libexec/src/bufio/bufio.go:414 +0x58
github.com/junegunn/fzf/src.(*Reader).feed(0xc20801e040, 0x4411ae8, 0xc2080ae000)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/reader.go:40 +0x6b
github.com/junegunn/fzf/src.(*Reader).readFromCommand(0xc20801e040, 0x41b7f30, 0x4c)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/reader.go:71 +0x1ac
github.com/junegunn/fzf/src.(*Reader).ReadSource(0xc20801e040)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/reader.go:26 +0x86
created by github.com/junegunn/fzf/src.Run
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/core.go:134 +0x67b

goroutine 7 [semacquire]:
sync.(*Cond).Wait(0xc20802a0c0)
        /usr/local/Cellar/go/1.4.2/libexec/src/sync/cond.go:62 +0x9e
github.com/junegunn/fzf/src/util.(*EventBox).Wait(0xc20801e060, 0xc208019780)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/util/eventbox.go:32 +0xaf
github.com/junegunn/fzf/src.(*Matcher).Loop(0xc20803a660)
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/matcher.go:67 +0x75
created by github.com/junegunn/fzf/src.Run
        /Users/jg/gosrc/src/github.com/junegunn/fzf/src/core.go:184 +0xa7d

goroutine 17 [syscall, locked to thread]:
runtime.goexit()
        /usr/local/Cellar/go/1.4.2/libexec/src/runtime/asm_amd64.s:2232 +0x1

Unfortunately, I don't know GO and don't know what to make of this. Any ideas?

from fzf.

junegunn avatar junegunn commented on May 13, 2024

Hmm, this is new to me. Something went wrong during ncurses initialization. Can you create a separate issue for this? And please share your tmux.conf.

from fzf.

mclearc avatar mclearc commented on May 13, 2024

You got it. See #305

from fzf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.