Git Product home page Git Product logo

Comments (5)

simeonschaub avatar simeonschaub commented on August 15, 2024

Just for reference, Wikipedia has a pretty good list of specs for FX processors: https://en.m.wikipedia.org/wiki/List_of_AMD_FX_microprocessors

from loopvectorization.jl.

chriselrod avatar chriselrod commented on August 15, 2024

I no longer call how I decided not to use:

using CpuId
cache_size = CpuId.cachesize()
num_cores = CpuId.cpucores()

https://github.com/chriselrod/VectorizationBase.jl/blob/master/deps/build.jl#L10

For AMD CPUS. Mind trying them and reporting what they return?
It would be better if we don't have to special case.

If that doesn't work, the problem is in CpuId.jl. If it does work, I should probably drop the checks.
Either way, the issue can be addressed in VectorizationBase, like @simeonschaub noted on discourse.

Otherwise, I'll add them. I also need to add Sys.CPU_NAME == "znver2".
What is your Sys.CPU_NAME?

from loopvectorization.jl.

lesshaste avatar lesshaste commented on August 15, 2024
julia> cache_size = CpuId.cachesize()
(16384, 2097152, 8388608)

julia> num_cores = CpuId.cpucores()
8

julia> Sys.CPU_NAME
"bdver1"

from loopvectorization.jl.

chriselrod avatar chriselrod commented on August 15, 2024

Looks like I may be able to just drop the special casing for AMD.

Do you know how I could test on zenv1 and zenv2?
I'm wondering if I should still special case these, or if they're properly supported. It isn't immediately obvious to me how to find out without access to them.

EDIT:
m-j-w/CpuId.jl@2ac67b0
Looks like as of July 2018, those functions should be supported on AMD.

I must have written the build script before that.

I'll just drop the special casing.

from loopvectorization.jl.

chriselrod avatar chriselrod commented on August 15, 2024

Fixed by
JuliaSIMD/VectorizationBase.jl@720d707

Update to VectorizationBase v0.1.8. I'll release a new LoopVectorization with that as the lower bound in the next few days.

from loopvectorization.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.