Git Product home page Git Product logo

Comments (6)

heitorPB avatar heitorPB commented on July 17, 2024

Where do I get those ReferenceImages? I'm trying to compile the docs here but it fails exactly there.

Currently docs/make.jl:15 looks for it in mediapath = joinpath(homedir(), "ReferenceImages", "gallery")

from makiegallery.jl.

asinghvi17 avatar asinghvi17 commented on July 17, 2024

github.com/SimonDanisch/ReferenceImages

from makiegallery.jl.

heitorPB avatar heitorPB commented on July 17, 2024

Why not move the ReferenceImages to this repository?

CC @SimonDanisch

from makiegallery.jl.

SimonDanisch avatar SimonDanisch commented on July 17, 2024

Because it's a huge repository with it's own release cycle. The release cycle already makes it a no-go to include it here, but if it wasn't, the other point is equally important: MakieGallery shouldn't be 340mb, since it can also used without actually comparing to the reference images!

from makiegallery.jl.

heitorPB avatar heitorPB commented on July 17, 2024

I came up to this repo because I wanted to add a few things to Makie Docs. But after a week trying to understand how Makie is organized, I still don't get it.

If I understood it:

  • JuliaPlots/Makie.jl: the metapackage for ploting.
  • JuliaPlots/MakieGallery.jl: a gallery of images and the documentation of Makie
  • SimonDanisch/ReferenceImages: another gallery of images needed to build the documentation.

Why there's two repos for a gallery of examples?

My suggestion:

  • move the docs to JuliaPlots/MakieDocs.jl
  • refacor SimonDanisch/ReferenceImages so it creates the images when needed (e.g. with julia make.jl), this way the repo will not be 340 mb.
  • Move Ref Images to the MakeDocs.jl repository, under a section/chapter Examples or Gallery, in a similar way of MatPlotLib's Gallery

This would make the life of random people wanting to help easier.

from makiegallery.jl.

github-actions avatar github-actions commented on July 17, 2024

Stale issue message

from makiegallery.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.