Can generated getSchema method always return same Schema instance? about avro-scala-macro-annotations HOT 4 CLOSED

Yes.

I see

public static final org.apache.avro.Schema SCHEMA$ = new org.apache.avro.Schema.Parser().parse(" ... 

With respect to naming, do you prefer schema to SCHEMA$?

With respect to timing, maybe tonight.

I don't mean to steal your fun! The fix for issue #1 gets us almost all the way there. The hard parts were:

1. what does a companion object definition look like when it is extracted/decomposed into its AST (err, into the quasiquote representation of its AST)
2. where to splice in such a definition

This ought to do the trick, pattern match in an annotated class and emit an updated class and companion object:

q"""$mods class $name[..$tparams](..$first)(...$rest) extends ..$newParents { $self => ..$newBody };
              object ${newTermName(name.toString)} { $newVal }""" 

from avro-scala-macro-annotations.

@julianpeeters awesome, glad this can be fixed! I'm pretty much indifferent on naming of the companion object schema field, although the Scala style guide says "Constant names should be in upper camel case" so maybe it should be named Schema?

from avro-scala-macro-annotations.

Sorry for any trouble this has caused you.

Does version 0.7 solve your issues? (Now up at Sontatype, syncing with Maven Central soon)

Was kinda locked into using "SCHEMA$" already, so without a strong objection, there it is, '$' in the name and all 🎱

from avro-scala-macro-annotations.

Just tested this out in 0.7 with the kafka schema registry - works great! Thanks a bunch for fixing this so quickly! 💯

from avro-scala-macro-annotations.