Comments (8)
Thanks for taking the time to look at all of this!
- This seems reasonable to me.
- This is definitely a typo, but I'm thinking about just reading straight to a dict and avoiding this exact function all together as I think it's unlikely enough people will be motivated to maintain a unique set of NIfTI like functions for a NIfTI header struct and ImageMeta. This is a great example, as a lot of software just defaults to qform or sform and ignores the other because it's too hard to figure out what everyone wants to do with it.
- Yes, this will be fixed. I've just been lazy.
- I think this may be related a work around I was trying to use to make CodecZlib work. It's suppose to be the fastest at gzip decompression right now, but it lacks a
seek
method for streams and that's really helpful for working around NIfTI's bizarre extension region. I'll probably just drop CodecZlib until someone creates a workable solution.
from nifti.jl.
@Tokazama: Any update on this? The design of this looks pretty good and I tested reading which seemed to work fine. Writing however not. I get ERROR: UndefVarError: scl_sclope not defined
if I call niwrite
.
from nifti.jl.
@Tokazama: I am trying to get the tests running but ran into several issues.
- First it seems that there are several files that are not checked in. Could you add them?
- Then I needed to comment in fileio.jl but I get
LoadError: File{DataFormat{:UNKNOWN}}
- The load functions seem to never call
niread
. Isn't that what they are supposed to do?
from nifti.jl.
Sorry for the delayed response. I'll take a look at this over the course of today.
from nifti.jl.
I'm working on fixing the errors mentioned here and writing better unit testing. I'll likely have something by the end of the day for further review. I'm also going to write down some details related to design choice and small changes I'll probably start working on #16. None of these should be user facing so it's likely of little concern to most.
from nifti.jl.
Great. Isn't the branch already implementing #16? Or do you refer more to the standardized parameter naming within the ImageMetadata?
from nifti.jl.
It may be worth trying this all out again if your interested. You will need to explicitly add NIfTI to your File IO registry for now ( see the tests for how to do this). Im working on a couple more things to really stress test the new implementation and then it should be good to go.
from nifti.jl.
I currently do not have the time to review so go ahead with merging, once you are confident with the design. I would be very interested in learning how to generate a nifti file from scratch. You have one load/ save example but this does not help, if one has just an array at hand.
from nifti.jl.
Related Issues (20)
- feature request/change HOT 1
- Why are method2 and method3 mutually exclusive? HOT 1
- Is this still active? HOT 1
- bug with Integer valued niftis HOT 9
- Transfer to the JuliaHealth organization? HOT 17
- Feature request: Reading and writing Bool datatype HOT 2
- TagBot trigger issue HOT 21
- Maybe a function is needed here to just read the header information HOT 3
- Confused about constructor HOT 1
- ArgumentError: invalid open mode: w9
- Bug in getaffine function HOT 1
- Reorient based on RAS/LPI HOT 2
- Files written by niwrite are corrupted HOT 8
- Consider making it difficult to make (u)int64 NIfTI images HOT 2
- InexactError: Int16(..) when accessing NIfTI with rescale_slope HOT 10
- NIfTI-2 support HOT 3
- mean of 3d nifti does not match calc by fslstats and 3dBrickStat HOT 2
- is this still active? HOT 1
- Missing fields for Freq_dim, Phase_dim and slice_dim within the nifti header after reading a nifti file. HOT 2
- Adding support for sform and qform matrices as fields within the loaded nifti file header. HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nifti.jl.