Segfault when writing variable length string as attribute about hdf5.jl HOT 8 CLOSED

julia> using HDF5

julia> fid = h5open("test.h5", "w")
🗂️ HDF5.File: (read-write) test.h5

julia> attr = create_attribute(fid, "attr-name", datatype(String), dataspace(String))
🏷️ HDF5.Attribute: attr-name

julia> val = Base.cconvert(Cstring, "attr-val") # ensures string is nul-terminated
"attr-val"

julia> GC.@preserve val begin
          p = Base.unsafe_convert(Cstring, val)
          write_attribute(attr, datatype(String), Ref(p))
       end

julia> close(fid)

julia> function write_variable_length_string_attribute(fid, attr_key::String, attr_value::String)
           attr = create_attribute(fid, attr_key, datatype(String), dataspace(String))
           v = Vector{UInt8}(attr_value)
           GC.@preserve v begin
               p = pointer(v)
               write_attribute(attr, datatype(String), Ref(p))
           end
           return nothing
       end
write_variable_length_string_attribute (generic function with 1 method)

julia> fid = h5open("test.h5", "w")
🗂️ HDF5.File: (read-write) test.h5

julia> write_variable_length_string_attribute(fid, "attr-key", "attr-value")

julia> close(fid)

shell> h5dump test.h5
HDF5 "test.h5" {
GROUP "/" {
   ATTRIBUTE "attr-key" {
      DATATYPE  H5T_STRING {
         STRSIZE H5T_VARIABLE;
         STRPAD H5T_STR_NULLTERM;
         CSET H5T_CSET_UTF8;
         CTYPE H5T_C_S1;
      }
      DATASPACE  SCALAR
      DATA {
      (0): "attr-value"
      }
   }
}
}

julia> using HDF5

julia> fid = h5open("test.h5", "w")
🗂️ HDF5.File: (read-write) test.h5

julia> function write_variable_length_string_attribute(fid, attr_key::String, attr_value::String)
           attr = create_attribute(fid, attr_key, datatype(String), dataspace(String))
           v = Vector{UInt8}(attr_value)
           v[end] == 0 || push!(v, 0) # null termination?
           GC.@preserve v begin
               p = pointer(v)
               write_attribute(attr, datatype(String), Ref(p))
           end
           return nothing
       end
write_variable_length_string_attribute (generic function with 1 method)

julia> write_variable_length_string_attribute(fid, "attr-key", "attr-value")

julia> close(fid)

shell> h5dump test.input
h5dump error: unable to open file "test.input"

shell> h5dump test.h5
HDF5 "test.h5" {
GROUP "/" {
   ATTRIBUTE "attr-key" {
      DATATYPE  H5T_STRING {
         STRSIZE H5T_VARIABLE;
         STRPAD H5T_STR_NULLTERM;
         CSET H5T_CSET_UTF8;
         CTYPE H5T_C_S1;
      }
      DATASPACE  SCALAR
      DATA {
      (0): "attr-value"
      }
   }
}
}

attrs(fid)["attr-key"] = "attr-value"

function write_variable_length_string_attribute(fid, attr_key::String, attr_value::String)
           attr = create_attribute(fid, attr_key, datatype(String), dataspace(String))
           v = Vector{UInt8}(attr_value)
           v[end] == 0 || push!(v, 0) # null termination?
           GC.@preserve v begin
               p = pointer(v)
               write_attribute(attr, datatype(String), Ref(p))
           end
           return nothing
       end