Git Product home page Git Product logo

Comments (3)

maleadt avatar maleadt commented on July 19, 2024

vswhere does not work with lightweight build tools, must install complete VS (or not rely on vswhere)

We can download vswhere if we start to rely on it.

CUDAdrv etc will all be broken.

Well, no, we just push an upper bound and fix the 2 usages of the API.

Since this package is called CUDAapi, what is the point of adding cuda to function names?

Consistency, as its find_library + find_cuda_library. But yeah, we can keep find_toolkit if you feel strongly about it.

I'll have a look at your proposed fixes tomorrow, but in general just propose a PR instead of listing them.

from cudaapi.jl.

denizyuret avatar denizyuret commented on July 19, 2024

from cudaapi.jl.

maleadt avatar maleadt commented on July 19, 2024

Yeah, the git workflow breaks down a little in that case. I typically self-comment using the Github UI to explain rationale, or use extended commit messages.

No worries though, I'll have a look tomorrow. Thanks for verifying on a variety of systems.

from cudaapi.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.