Type stability for GPs about abstractgps.jl HOT 6 CLOSED

@kaandocal is this now resolved as #291 is merged?

from abstractgps.jl.

Shouldn't you use

typeof​(​posterior​(​gp​(X2, ​0.01​), Y2))

in your comparison?

BTW your comparison doesn't guarantee type stability, you would want to check if the type can be inferred correctly. This can be done e.g. with @code_warntype and @inferred.

from abstractgps.jl.

My fault, I forgot the second typeof (the result doesn't change however). Just to clarify, by type stability I meant that adding more observations to a GP changes its type in this case!

from abstractgps.jl.

I can't check it right now but I assume that the problem is a missing vcat definition for ColVecs, so the type changes when concatenating X1 and X2. Does it work with regular vectors for X1 and X2?

from abstractgps.jl.

That is indeed the problem! For 1-dimensional vectors X1 and X2 it works. I'll create a PR in KernelFunctions.jl.

from abstractgps.jl.

I'll take that as a yes 🙂

from abstractgps.jl.