Comments (6)
Yeah, I don't have the time for that either. I'll just blacklist the package.
from awss3.jl.
The CI runs on a public AWS account provided by Invenia so we can do some integration testing for uploading, deleting, etc. objects.
If these secrets were added into PkgEval would that resolve the issue?
from awss3.jl.
If these secrets were added into PkgEval would that resolve the issue?
No, adding secrets (or other environmental information) to PkgEval on a per-package basis is not a scalable solution.
from awss3.jl.
If these secrets were added into PkgEval would that resolve the issue?
No, adding secrets (or other environmental information) to PkgEval on a per-package basis is not a scalable solution.
I'm not quite sure what the path forward is here in that case. We need to limit access to the AWS account, but still be able to test the package concretely.
I would not want to add in special code checking for PkgEval env vars and restructuring tests to have it work as this is not a dependency of this package.
We could create a public bucket in the account and place some objects in there, restructure tests to separate ones which do and do not require credentials. But that limits things to read only operations and does not seem value.
from awss3.jl.
I would not want to add in special code checking for PkgEval env vars and restructuring tests to have it work as this is not a dependency of this package.
You only need to check an environment variable. Why is that problematic? It's generally a good thing that registered, public packages can be tested without special set-up.
Alternatively, CloubBase.jl's minio
wrapper could be used to create a public, S3-compatible environment, e.g., https://github.com/JuliaLang/BugReporting.jl/blob/00d09eede70ec9e3784e4f83ac26d338460fff6b/test/rr.jl#L104-L116
Ultimately though, I don't really care about AWSS3.jl's PkgEval-compatibility, so feel free to close. The only disadvantage is that this package won't be considered when testing for upstream Julia changes.
from awss3.jl.
You only need to check an environment variable. Why is that problematic? It's generally a good thing that registered, public packages can be tested without special set-up.
IMO, this package as well as AWS.jl and others are a bit more unique where if you're using them there's somewhat of an expectation that you have AWS credentials present. Although they do support credential-less requests, as part of testing you would want to test that your changes and nightly runs check everything.
Alternatively, CloubBase.jl's
minio
wrapper could be used to create a public, S3-compatible environment, e.g., https://github.com/JuliaLang/BugReporting.jl/blob/00d09eede70ec9e3784e4f83ac26d338460fff6b/test/rr.jl#L104-L116
Ultimately though, I don't really care about AWSS3.jl's PkgEval-compatibility, so feel free to close. The only disadvantage is that this package won't be considered when testing for upstream Julia changes.
Using MinIO would work, could refactor this to:
- Run tests against MinIO
- If credentials are present, run them on AWS
Personally I do not have the time to make these currently, if you make the PR though I can review though. Honestly this package really needs to be re-written anyways so I'm not too concerned about its current state that much.
from awss3.jl.
Related Issues (20)
- Add support for DeleteObjects
- `s3_get_file` allocates the whole file in memory before writing to disk HOT 1
- AWS version locked to 1.63.1 which limits us to HTTP 0.9? HOT 3
- Add a progress indicator hook
- no matching method found convert(::Type{Ptr{EzXML._Node}}, ::EzXML.Node) (1/2 union split):
- `S3Path` constructor does not respect its type parameter
- Support S3 Transfer Acceleration
- Config not passed along when concatenating with string
- Base.read method partially supported
- Documenting Cloudflare R2 Support
- Support returning versionId on s3 `write` HOT 4
- Update CI to use new AWS account
- Testing against MinIO doesn't restrict permissions
- Separate tests into unit and integration tests
- Add S3Path constructor where you just pass in an S3Path and a version HOT 1
- Clearly differentiate functions that accept prefix vs. key HOT 1
- S3Path implements `getproperty` but not `propertynames`
- InexactError: trunc(Int32, 6203998800) error when writing large file to S3 using Slimgroup's SegyIO HOT 1
- Issue using readdir on root bucket HOT 2
- `s3_get_file` error not useful when incorrect `region` is used
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from awss3.jl.