Missing calls to parse_constraints in model.py about python-libjuju HOT 5 CLOSED

Fixing this should be as simple as finding instances of the string "constraints" in model.py, and replacing where appropriate with parse_constraints(constraints).

from python-libjuju.

Working on this now. It looks like it's not as simple as naively adding parse_constraints -- I get errors on the core side, and may have to make the logic in parse_constraints more sophisticated. :-/

from python-libjuju.

This bug has unveiled a whole tangle of fun issues:

1. We needed to parse_constraints in more places -- I've done that locally.
2. We need to convert CamelCase in the AddMachines params to snake_case -- I've done that locally, though the code needs some neatening up.
3. If a .yaml specifies an lxd container or a machine, we need to parse that into two Placement objects -- I've done that locally.
4. If a .yaml specifies lxc containers, it looks like we need to setup lxd containers instead. I'm working on that, though my first pass at a fix isn't working :-/

from python-libjuju.

Update: I've addressed point 4, from the previous comment, in a branch, but I'm now getting a failure getting haproxy up. Either there's a bug in 3 (Placement objects aren't making lxd containers correctly), or we're missing something that haproxy needs (it looks like it's complaining about missing a config value).

Will continue to work on this ...

from python-libjuju.

A lot of this issue was fixed in #37

The remaining issue is open in launchpad here: https://bugs.launchpad.net/juju-core/+bug/1651260

Will open a new issue here if we need to do more work after addressing the launchpad bug.

from python-libjuju.