Git Product home page Git Product logo

Comments (5)

juho-p avatar juho-p commented on August 20, 2024

This looks interesting. It takes some time (slightly busy at the moment) for me to see what you have actually done before I can merge (or cherry-pick) these. At least those fixes will probably get merged in near future.

from fatty.

paolo-sz avatar paolo-sz commented on August 20, 2024

That's fine. It took me pretty a lot of time just to, more or less, blindly merge all the commit from mintty tree so I understand that putting some more brain in the work can take a lot of time. In the meanwhile I will use this version and I will try to fix any misbehavior I will find (I have already found some little ones).
By the way, I have really a bad feeling with git and "she" probably has a bad feeling with me too so be prepared to some damned push made wrong... sigh...

from fatty.

paolo-sz avatar paolo-sz commented on August 20, 2024

I just started to find issues on my changes prior to mintty update. I made a fix but this could became a mess for you when you will start the review so I created a branch (fixes2original) where all the new features are not included.

from fatty.

juho-p avatar juho-p commented on August 20, 2024

Thanks for your fixes. Sorry it took so long for me to look into this. I merged your fixes2original branch. I didn't have time to test it very well though so I hope it works out well... I commented the code in your repository but those were just some ideas for you to consider and not that bad problems.

I'm still considering if I can merge your master-branch.

from fatty.

paolo-sz avatar paolo-sz commented on August 20, 2024

Really, do not worry at all, I understand people have something called "real life"... :-)

Take your time and do not feel obliged in any way.

from fatty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.