Comments (7)
Because I love (and not only me, ofc) to follow readmes and docs, but if they do not helps I go to the tests, if there's no tests or they are so ugly, Im forced to go to the source which is waste of time, then Im forced to follow the deps chain and etc and etc.
from jstransformer.
Need MOAR proof of #16 ? Please, try run this
var hogan = require('jstransformer')(require('jstransformer-hogan'));
var compiled = hogan.compile('<p>Hello, my name is {{name}}.</p>');
var result = compiled.fn({name: 'foobar'});
console.log(result);
mm?
from jstransformer.
#19 fixes this by the way.
from jstransformer.
@tunnckoCore, fixed: jstransformers/jstransformer-hogan@2ea0763. I think you have a point on #16, but please discuss with @ForbesLindesay more on that topic on #16 before we can adopt a project-wide policy.
@hemanth See above commit. For later contributions please always make compile()
self-contained. And when you get a chance please add me as owner and tag and publish v0.0.2. Thanks.
from jstransformer.
@tunnckoCore, fixed: jstransformers/jstransformer-hogan@2ea0763.
yea, just notice it. and #19 still not fixes this
from jstransformer.
Fixing things like this belong in the jstransformer tests. We know the tests for jstransformer are very incomplete, and that's why we haven't caught all the bugs yet. Please stop attempting to test jstransformer in the test suites for other libraries.
from jstransformer.
If you need more convincing, check out where the test coverage is currently lacking, relative to where you found a bug:
https://coveralls.io/builds/2333120/source?filename=index.js
from jstransformer.
Related Issues (20)
- jsx-template
- Mermaid: Data Flow Diagrams
- Polished CSS
- Ibra
- markdown-in-js
- thysultan/jsx.js - small and extensible transpiler HOT 1
- Switch to npm organization HOT 2
- Support sync rendering even of async transforms
- Emoji
- jQuery View Engine
- blockml HOT 1
- Typescript/JavaScript to C
- imagemin
- lit-html
- Mark
- trademark/copyright issue on logo HOT 3
- Prepack
- renderAsync can throw synchronously, should return a rejected promise instead? HOT 1
- Slack Group? HOT 3
- An in-range update of is-promise is breaking the build 🚨 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jstransformer.