Git Product home page Git Product logo

Comments (7)

tunnckoCore avatar tunnckoCore commented on June 16, 2024

Because I love (and not only me, ofc) to follow readmes and docs, but if they do not helps I go to the tests, if there's no tests or they are so ugly, Im forced to go to the source which is waste of time, then Im forced to follow the deps chain and etc and etc.

from jstransformer.

tunnckoCore avatar tunnckoCore commented on June 16, 2024

Need MOAR proof of #16 ? Please, try run this

var hogan = require('jstransformer')(require('jstransformer-hogan'));
var compiled = hogan.compile('<p>Hello, my name is {{name}}.</p>');
var result = compiled.fn({name: 'foobar'});

console.log(result);

mm?

from jstransformer.

TimothyGu avatar TimothyGu commented on June 16, 2024

#19 fixes this by the way.

from jstransformer.

TimothyGu avatar TimothyGu commented on June 16, 2024

@tunnckoCore, fixed: jstransformers/jstransformer-hogan@2ea0763. I think you have a point on #16, but please discuss with @ForbesLindesay more on that topic on #16 before we can adopt a project-wide policy.

@hemanth See above commit. For later contributions please always make compile() self-contained. And when you get a chance please add me as owner and tag and publish v0.0.2. Thanks.

from jstransformer.

tunnckoCore avatar tunnckoCore commented on June 16, 2024

@tunnckoCore, fixed: jstransformers/jstransformer-hogan@2ea0763.

yea, just notice it. and #19 still not fixes this

from jstransformer.

ForbesLindesay avatar ForbesLindesay commented on June 16, 2024

Fixing things like this belong in the jstransformer tests. We know the tests for jstransformer are very incomplete, and that's why we haven't caught all the bugs yet. Please stop attempting to test jstransformer in the test suites for other libraries.

from jstransformer.

ForbesLindesay avatar ForbesLindesay commented on June 16, 2024

If you need more convincing, check out where the test coverage is currently lacking, relative to where you found a bug:

https://coveralls.io/builds/2333120/source?filename=index.js

from jstransformer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.