Git Product home page Git Product logo

Comments (9)

jhugobb avatar jhugobb commented on June 3, 2024 1

There you go 👍 don't forget to put the "Fixes #118" in the description of the PR so it can be linked to here and identified for Hacktoberfest! @emilyy1231

from jsonmc.

emilyy1231 avatar emilyy1231 commented on June 3, 2024

Ooo, I got it!

from jsonmc.

emilyy1231 avatar emilyy1231 commented on June 3, 2024

I'm relatively new to programming, so I was just wondering what this JSON collection could potentially be used for? Couldn't you just parse and store all the movies on IMDB?

Also, just made pull request fort the .json file

from jsonmc.

jhugobb avatar jhugobb commented on June 3, 2024

Did not find the PR that you mention, is it ok if I submit my own?

from jsonmc.

emilyy1231 avatar emilyy1231 commented on June 3, 2024

@jhugobb Hmm, I'm pretty sure I made a pull request. Let me double check. Thanks for asking.

from jsonmc.

jhugobb avatar jhugobb commented on June 3, 2024

If you forked the repository make sure you made the pull request in this repo and not on your own :D @emilyy1231

from jsonmc.

emilyy1231 avatar emilyy1231 commented on June 3, 2024

@jhugobb it says "emilyy1231 wants to merge 1 commit into master from emilyy1231-patch-1", so I think I did it right - let me know!
finding_forrester_pr

from jsonmc.

jhugobb avatar jhugobb commented on June 3, 2024

Thats your repository, note that the name above says "emilyy1231/jsonmc". That's because that is your version of it. You need to go to the jsonmc/jsonmc repo (aka this one) and submit a pull request between forks. Then something in here should say you opened one if you mention "Issue #118" in the PR description. @emilyy1231

from jsonmc.

emilyy1231 avatar emilyy1231 commented on June 3, 2024

@jhugobb Ahhhh, thank you thank you. Just submitted the pull request.

from jsonmc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.