Remove `compressible: false` entries about mime-db HOT 12 CLOSED

this is supposed to be the only db any mime lib should need. but yeah, a lot of those are unnecessary. probably gonna remove the ones added by scripts/build.js

from mime-db.

Just remove all of them and check if the property exists haha.

from mime-db.

Actually I like them there, because it communicates three things

true it is compressible
false it is not
undefined we don't know

from mime-db.

i think the falses in lib/compressible.json is fine. i'm thinking about removing these guesses since it can be done by the higher level lib: https://github.com/jshttp/mime-db/blob/master/scripts/build.js#L61

from mime-db.

@jonathanong it should be based off IANA, yes. the way it is was just subjective by your regular express, which would belong somewhere else :)

from mime-db.

How do exactly do we plan on basing it off IANA?

from mime-db.

We just have to read the registered RFCs I guess. For example RFC 6838 states that text/* is only for data that is primarily textual, so based on that, we can blanket say everything there is compressible or something. There is also the RFC for the +xml and +json suffixes, which state what the mean, so we can do the same there: say they are all compressible or something.

the more i think about it, though, the more this sounds like a job for compressible module, really, to contain these mappings?

from mime-db.

the more i think about it, though, the more this sounds like a job for compressible module, really, to contain these mappings?

Well that's what I said in the first place. It doesn't really make sense here, but it does reduce duplication I... guess?

from mime-db.

my goal here is to reduce duplication :)

from mime-db.

yea. i talked to @jonathanong on irc and i changed my mind

from mime-db.

k leaving the compressible stuff here. i also removed all the regexp checks for compressible and charset. higher level libs can do the regexp checks themselves

from mime-db.

higher level libs can do the regexp checks themselves

👍 make this more like a plain database :)

from mime-db.