review about mime-db HOT 27 CLOSED

can you go ahead and publish as 0.0.0 just so we have the npm name claimed? :) i'm going to review it right after i get the destroy fix stuff out

from mime-db.

nvm, it was already done :D

from mime-db.

there is an issue with tests, because there seem to be nothing to test :D

from mime-db.

there are tests haha no coverage though

from mime-db.

Hmmm, these are missing their file types. (does this belong in a new issue? idk haha)

https://github.com/jshttp/mime-db/blob/master/db.json#L6746-L6751

Keep in mind jshttp/mime-types#7 :S

from mime-db.

jshttp/mime-types#7 should be up to the user-facing lib

from mime-db.

Ok, well the file extension should still be added to them before 1.0.0 though.

from mime-db.

i don't think x-shader is a registered type at all

from mime-db.

Which is why it should be in the extensions: https://github.com/jshttp/mime-db/blob/master/lib/extensions.json

from mime-db.

well, i mean you have the format <type>/<subtype>; technically any unregistered <type> is invalid, though for <subtype> it's blurry :)

from mime-db.

(sadly the internet doesn't care if it is invalid)

Yes, it should be application/x-fragment-shader, but it isn't. WebGL applications already use this extensively.

from mime-db.

right. one thing i think would be nice is if the db entry like listed the source, so you could tell if it was some "official" type or something we added

from mime-db.

Types we added are in the "extensions" file, so it's build script could do that, yeah.

from mime-db.

i thought that would be a little too noisy for the user-facing db. users can lookup src/ and lib/ if they want to know how we got particular data.

from mime-db.

you mean like doing require('mime-db/src/iana')? i don't really like relying on that node module behavior, personally :)

from mime-db.

oh no i didn't include it in the package. i mean actually going to the repo. why would you need to know this information during runtime?

from mime-db.

because... it's there :) personally i would want it for trying to strictly validate something by not allowing de-facto crap

from mime-db.

okay i guess we can add it. i just didn't want the the JSON file to hit 1mb. lol.

from mime-db.

another issue is that you'd want to know the source for different aspects. the source for the mime type, the source for each extension, the source of whether it's compressible. might get too complicated to do correctly

from mime-db.

hm, yea. i was only thinking the source of the mime type itself, but i see about the others. we can just ignore it, haha. but i did notice there is no default charset info in there, right?

from mime-db.

you mean from iana or what? i only grabbed the mime types from iana. there are a lot of other info we can grab from them, but i don't really know what they mean haha

from mime-db.

what's the other info you can easily grab?

from mime-db.

here are some parameters:

• http://www.iana.org/assignments/media-types-parameters/media-types-parameters.xhtml
• http://www.iana.org/assignments/media-type-sub-parameters/media-type-sub-parameters.xhtml

that's just from the mime types page http://www.iana.org/assignments/media-types/media-types.xhtml. haven't looked anywhere else for more data

from mime-db.

oh, yea, imo neither of those are useful to us here

from mime-db.

@jonathanong Looking...

from mime-db.

@Fishrock123 it's not here because you didn't add it to mime-types either: jshttp/mime-types#7. feel free to add it yourself - i know nothing about these types haha

from mime-db.

@dougwilson added .source: iana.

going to close this for now. open new issues for anything else.

from mime-db.