Comments (9)
No problem. My notes on the pull request itself will probably be better to help you understand than the commits. The reason is that in one commit I might have done something that worked, but then found a better way and committed that later. We can continue that conversation on the pull request itself. :)
from csharpprolog.
I see now I can add an issue to my own fork if I enable it. However, since you ported it from JohnPool's original repo I'm wondering if anything was intentionally left off and if I should even bother trying to dig it up. Thoughts? Thanks in advance.
from csharpprolog.
Thank you for your reporting!
I'm sorry to late because I was very busy for another some projects.
Anyway, I'll figure out this issue.
from csharpprolog.
I researched about this issue on internet for a few hours.
The result of researching is this:
Fact
- "CHAT-80" is a software that is copyrighted by Fernando Pereira.
- "CHAT-80" is not a part of CSharpProlog. CSharpProlog is not licensed to redistribute "CHAT-80".
- "chat" predefined predicate of CSharpProlog is provided for just a shortcut to launching "CHAT-80", for convenience to users.
- Getting "CHAT-80" program files, and storing it into "chat-80" subfolder, are responsible of individual users.
- But, today, original "CHAT-80" program files were gone due to the distribution point web site (http://www.cis.upenn.edu/~pereira/oldies.html) was closed.
- I found a part of "CHAT-80" program files in internet archives. But it is not full set, so we can't try "chat" predicate.
Conclusion
I will remove "chat" predicate from predefined predicates, and release new version of CSharpProlog.
from csharpprolog.
P.S.
I found "SAMPLES, TESTING & EXPERIMENTAL" section in predefined predicates.
That section include like these noisy predicates... :O !
age( peter, 7).
age( ann, 5).
age( ann, 6).
age( pat, 8).
age( tom, 5).
I think that these predicates are not suitable for predefined predicates.
Therefore, I'll remove all of the "SAMPLES, TESTING & EXPERIMENTAL" section from predefined predicates.
from csharpprolog.
I think that's a great idea. I'm going to submit a pull request for what I've been doing. If nothing else I'd like your comments on it. Nothing major (added a dotnetcore console app that works in linux, updated help text, etc). I THINK it will merge okay with the changes you are suggesting. I just don't want our forks to diverge too far.
from csharpprolog.
Thank you for your contributions!
I found your pull request on this GitHub repository.
I'll merge your pull request after I understand what did you do.
Unfortunately, I have a task that higher priority just now, so please give me one or few days to merge your pull request.
from csharpprolog.
P.S. I'm started using GitHub project feature.
See: https://github.com/jsakamoto/CSharpProlog/projects/1
from csharpprolog.
I did it at 5f00b5e
from csharpprolog.
Related Issues (20)
- Console versions should not change console properties HOT 9
- Fix a big mistake - GitHub default branch configuration (and branch strategy) HOT 1
- AppVeyor reported build failed since issue #9 was fixed HOT 1
- GetAllSolutions only works if you pass in a file HOT 1
- Implement persistence of command history feature on .NET Standard edition
- "CsPrologHelp.txt" file which has been mentioned in "ShowHelp" method is missing.
- Create and publish v.6 package. HOT 2
- Chat and Chat80 still listed in help predicate listing HOT 1
- Create more Issues for Desired Unit Tests
- PLw Project Needs some Attention
- How can a fact be queried ? HOT 3
- Font and Console Colors Should Not be Modified w/o Users Permission
- Enhancing collaborability HOT 3
- Documentation HOT 13
- Can not add the same root fact twice by "ConsultFromString()" method. HOT 2
- Import Custom Predicates
- Does constraints work? HOT 3
- Best way to make the PrologEngine available in an app? HOT 3
- Query result includes variable name? HOT 7
- Documentation for CSProlog HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csharpprolog.