Use makey? about js2-refactor.el HOT 13 OPEN

@NicolasPetton I am not proposing to discard the keybindings. Rather, I think we should integrate with emr additionally. I will do that soon.

from js2-refactor.el.

This sounds pretty useful. :)

Would it be an idea to coordinate a little with @darth10, re the same effort being done for clojure-emacs/clj-refactor.el#36

The idea there was to use the popups from magit. Maybe makey is better? I haven't look at it.

from js2-refactor.el.

@magnars I thought that makey was from magit :/ I haven't looked deeper at magit's internals though.

from js2-refactor.el.

@tarsius I saw some comments related to magit-popup, would it make sense to wait for it to be released?

from js2-refactor.el.

This does sound similar to the work I did in this PR via a new minor mode. Unfortunately, this PR created a new headache - maintaing the new minor mode.

IMHO I think @tarsius is refactoring Magits source to make this possible.
I had a plan of integrating it once he's done.

If makey does the job in a clean and maintainable way, I see no reason for not incorporating it.

Good luck on that PR @NicolasPetton 😄

from js2-refactor.el.

Unfortunately I got sidetracked working on other parts of magit, and so I have not yet made the changes to magit-popup that make it useful for other packages. Most importantly the api is still subject to major changes.

So I would recommend you stick with makey, for a while at least. It is more geared toward being used as a basic command dispatcher. magit-popup puts the focus on also picking arguments for these commands. In short there is but one hard coded "command" section, and while I intend to fix that there are other things I will work on first.

from js2-refactor.el.

ok, thanks! makey it is, then :)

from js2-refactor.el.

Bump!

Any updates on this?
It's been quite a while since the last update 😄
Perhaps we have alternatives now too?

from js2-refactor.el.

magit-popup could be used now. Would it still be useful?

However, AFAIR there was an issue with multiple-cursors used from within interactive functions. Is it still the case?

/cc @magnars @darth10

from js2-refactor.el.

@NicolasPetton I would really like to see magit-popup being used to show the key bindings interactively.
The multiple-cursors issue is something completely new to me though, so not really sure about that.
It would be great to see a PR for it though! Perhaps we could even port it to clj-refactor.el.

from js2-refactor.el.

We could use hydra, as in this snippet: https://gist.github.com/anachronic/7af88c62db136727cd1fed17ee0a662f

I'm not sure if js2-refactor should use hydra by default (and thus require it, or if it should be optional).
@magnars what do you think?

from js2-refactor.el.

There is also emr.

from js2-refactor.el.

@nbfalcon True, but I like the mnemonic keybindings of js2-refactor more.

from js2-refactor.el.