Comments (13)
I think at a minimum we should at least change the border colour. The native HTML input validation renders a tooltip when trying to submit without a lesson title like so:
I think changing the border colour is something we should definitely do – maybe adding a tooltip/pop-up is a nice-to-have. You could take that on if you wanted to? Or maybe add the border colour for validation for this issue and tackle a tooltip/pop-up in another, follow-up issue ?
from dev-jot.
I think, there's different approaches for this:
- Notify the user via pop-up
- Modify the text within the fields: "Can't add empty lessons."
- Add some different style to the empty field, so the user notices. Maybe change the border.
Maybe, the better option is the less invasive for the user.
What do you think?
from dev-jot.
Yes, I'll give it a go. I'll first focus on adding the border colour in the respective use cases and then maybe address the tooltip/pop-up.
from dev-jot.
Awesome! Sounds good
from dev-jot.
Hi, can I look into this issue?
from dev-jot.
Hi, can I look into this issue?
Hey! Unfortunately this issue is already being worked on.
from dev-jot.
Looking for a first issue to contribute here. Can you point me to a good one please?
from dev-jot.
Looking for a first issue to contribute here. Can you point me to a good one please?
Take a look at #113. That's a good one to start with. If you want I can assign you to it?
from dev-jot.
Looks good for me. I finally have the opportunity to tackle SASS/SCSS
from dev-jot.
Looks good for me. I finally have the opportunity to tackle SASS/SCSS
from dev-jot.
I see there are 2 versions. I want to work with the react version. Can I clone that version only? Which version does git clone https://github.com/jrobind/dev-jot.git clone ?
from dev-jot.
This ticket is just for the vanilla app. The react version uses styled components and material ui so this ticket doesn't apply.
from dev-jot.
Hi,
I have made some changes in the ui can i make a pull request!
from dev-jot.
Related Issues (20)
- Download lesson notes as markdown files HOT 5
- Fix modal text alignment HOT 4
- issue in removing the lesson while editing it. HOT 3
- Create footer component (React version) HOT 2
- Convert CSS to SASS/SCSS – vanilla app HOT 11
- Create Lessons form component – React HOT 3
- Add unit/integration testing HOT 3
- Changing header title color to blue HOT 2
- Add Open Graph meta tags and improve 'description' meta tag HOT 1
- Tags are not stored in local storage HOT 2
- Add unit tests for react app HOT 3
- Refactor react components HOT 1
- Rich UI components HOT 2
- Lesson content extends beyond container when viewing HOT 4
- Implement lesson cards for app-react HOT 4
- Suggestions for improving the repo
- When i start the vanilla app with live server it giving me a alert called Service Worker registration failed. HOT 1
- Notes to pdf HOT 1
- UI suggestion
- Clicking clear button in edit view reverts text for submit button HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dev-jot.