Git Product home page Git Product logo

Comments (3)

cosmicexplorer avatar cosmicexplorer commented on July 21, 2024

Yeah, I didn't think about this too long before I implemented it. I wanted to avoid having miscapitalized versions of languages alongside the real ones, so markdown-add-language-if-new won't add it to the corpus, and will instead return the element of the corpus that does have the "appropriate" capitalization, if the result of completing-read ("Fortran" in this case) is a differently-capitalized version of a language in the corpus.

I'm thinking let's just drop the attempt to squash capitalization and instead add all capitalizations of a language to the buffer-local corpus as they are added, and then return the unmodified language string that the user entered (as you would expect in this case). Do we want to (let ((completion-ignore-case nil)) then so the user has to confirm a different capitalization (just once per capitalization, though)? Or no?

from markdown-mode.

jrblevin avatar jrblevin commented on July 21, 2024

I think I misread your comments/commit messages regarding capitalization. I thought you meant for it to do this already. In any case, I think it would be good to add all capitalizations used. I suppose it should ask for confirmation (once) for the sake of consistency within a file.

from markdown-mode.

cosmicexplorer avatar cosmicexplorer commented on July 21, 2024

Cool, so if the user enters a capitalization of a language it hasn't seen before, it'll ask to confirm (once) and add it to the corpus just as if it was a new language. I'll make a pr.

from markdown-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.