Can markdown-mode cause problems with query-replace? about markdown-mode HOT 8 CLOSED

Which emacs version do you use ?

from markdown-mode.

On Windows:
GNU Emacs 24.5.1 (x86_64-w64-mingw32) of 2015-09-02 on WARLOCK
On Linux:
GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.18.6) of 2016-01-11 on utensil

from markdown-mode.

I cannot reproduce this issue as below on Ubuntu 15.10 with Emacs 24.5.

Can you reproduce this issue by emacs -Q -l markdown-mode.el ?

from markdown-mode.

Funny thing. It's there, then it isn't.

Since I'm currently @work I'm under Windows. Setup is:

working directory: ~\AppData\Roaming.emacs.d\elpa\markdown-mode-20160223.537

$ md5sum.exe markdown-mode.el markdown-mode-2_1.el
483fb4f4f18b4856247d823068bb8c70 *markdown-mode.el
9a5b233ff6cc83cc9ab68c059c534620 *markdown-mode-2_1.el

emacs -Q -l ./markdown-mode.el test.md

query-replace /salsa/ with /sals/ -> error args out of range

emacs -Q -l ./markdown-mode-2_1.el test.md

query-replay /salsa/ with /sals/ -> no problem.

I've attached a ZIP with the test.md file. I'm really curious, if you're now going to see the same problem.

test.zip

from markdown-mode.

Thanks for this report. Indeed, markdown-mode can cause problems with query-replace and it has happened before, back in 2011. The fix (eacccad) required placing save-match-data around a function used in after-change-functions. Therefore, if it is due to markdown-mode in this case it is probably related to my changes yesterday in da1cf8d, which removed save-match-data in two places to speed up fontification. I will look into it.

from markdown-mode.

Thanks a lot. That I see the "args out of range" error is basically fresh. I believe I'm seeing this with my update of markdown-mode to 20160223.537. Before that, I only saw the effect, that only the first item was replaced during a query-replace. I would say, that I noticed it about a week ago, that query-replace behaved not quite kosher in markdown buffers.

from markdown-mode.

Hi, I just noticed the commit to #105, download markdown-mode.el from a2a1b5f, byte-compiled it and restarted Emacs.

I'm more than happy to confirm, that my query-replace problem really is gone now.

Great work, Thank you so much.

from markdown-mode.

Great, thanks for reporting this and for confirming that it is fixed!

from markdown-mode.