CurrencyHandler duplicate keys in Currencies dictionary causes exception about morestachio HOT 5 CLOSED

Thanks for the detailed bug report. Could you anyway post a stacktrace? After the last bugfix there is a selection that even if a duplicate exists, the first in order will be evaluated. In the meantime I will prepare a fix for that anyway to allow duplicate entries.

If you need a quickfix, you could mitigate the bug by overwriting the CurrencyHandler.DefaultHandler and provide your own list of currencies.

from morestachio.

I dont think you are running on the latest release that includes the bugfix. I read through your report and you said

grouping by LCID and CurrencyEnglishName (lines 17 through 33 in CurrencyHandler.cs).

That was pre-fix. After the fix on the current release the code is now like this:

static CurrencyHandler()
	{
		IDictionary<string, Currency> GetSystemCurrencies()
		{
			return CultureInfo.GetCultures(CultureTypes.SpecificCultures)
				.GroupBy(e => e.LCID)
				.Select(f =>
				{
					//this has to be tried because in some systems we can get invalid regions
					try
					{
						return new RegionInfo(f.Key);
					}
					catch (Exception)
					{
						return null;
					}
				})
				.Where(e => e != null)
				.GroupBy(e => e.ISOCurrencySymbol)
				.Select(f => f.First())
				.ToDictionary(e => e.ISOCurrencySymbol, e => new Currency(e.CurrencySymbol, e.ISOCurrencySymbol));
		}

		DefaultHandler = new CurrencyHandler(GetSystemCurrencies);
	}

That should negate the effects of duplicates.

from morestachio.

Thank you, I will double-check my results with the code you posted above.

Here is the requested stack trace:

from morestachio.

Thank you for the prompt response. You are correct, it was not the latest code that was causing the exception. I will close this issue post haste.

from morestachio.

No worries glad to help :-).

from morestachio.