Implementation design about xhook HOT 4 CLOSED

I submitted a patch for the particular issue I was facing in #69, but am still curious re the design.

from xhook.

Hi @jiangts by using a facade version of XMLHttpRequest, we can intercept everything and modify anything. A brief glance at ajax-interceptor tells me that it creates a global readystatechange event handler and not much else...

Thanks for the PR! Any and all fixes to non-adherence to the spec are greatly appreciated :)

from xhook.

Right -- ajax-interceptor also seems to only override 1 method on the original XMLHttpRequest object at a time. Obviously, there are tradeoffs, but this seems like a wise approach in order to ensure the API to the "tainted" XMLHttpRequest object continues to be consistent.

I spent a couple hours debugging some weird code with req.responseType = 'arraybuffer' last night to no avail -- xhook was still returning the response as a string rather than arraybuffer type.

from xhook.

That's strange, responseType should just be set on the underlying XHR object... It'd be great if you could make a simple HTML page demonstrating the issue and post a link to it on new issue. Closed with #69.

from xhook.