Git Product home page Git Product logo

Comments (5)

morsdyce avatar morsdyce commented on September 26, 2024

I'll look into it, but will appericiate a failing example in case I can't reproduce.

from xhook.

morsdyce avatar morsdyce commented on September 26, 2024

I confirmed the bug and reverted the change for now until we understand what exactly is the issue.
For now if angular 2 needs this change you can use version 1.4.0 from npm.

Can you please specify why angular 2 needed this change and how I can test it?
I'd like to see what exactly is the issue when the facade is missing these properties.

from xhook.

BaTbAbYDeV avatar BaTbAbYDeV commented on September 26, 2024

Thanks for confirming and updating - much appreciated!

@Abrissirba - do you have the insights into Angular 2 and the reasoning for these facade extensions? (Thanks!!)

from xhook.

morsdyce avatar morsdyce commented on September 26, 2024

Hi @Abrissirba,

I know it's been a while but I would love if you could provide more info about the fix you submitted that was mentioned here.
I tested Angular v2 & Angular v4 and was able to use xhook with them as intended so I could not understand why that fix was needed.

Let me know if you consider this to still be a problem with that change being reverted so we can try to understand what happens better.

Thanks!

from xhook.

morsdyce avatar morsdyce commented on September 26, 2024

Closing this as this issue has become stale, please let me know if this is still a concern.

Thanks

from xhook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.