Error callbacks never fire on versions after 1.1.8 about xhook HOT 7 CLOSED

Sounds like I broke something :) looking into it now

from xhook.

I'm fairly certain it has to do with the load and loadend events

from xhook.

Yep, I changed that recently because load should not fire when there's an
error and it was

On Sun, May 11, 2014 at 3:25 PM, Brian Mann [email protected]:

I'm fairly certain it has to do with the load and loadend events

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-42762588
.

from xhook.

Yah I can see you're only firing loadend events for success status codes in the 2xx range.

Per the spec: loadend: The request has completed (either in success or failure).

So loadend should fire for both success or failure.

I'm not sure if load is only for true "success" -- as in 2xx status code or for the more general "completed" which would be whenever the server sends back anything -- irrespective of status codes, etc.

from xhook.

https://github.com/jpillora/xhook/blob/gh-pages/src/xhook.coffee#L230-L231

So loadend should fire for both, and load for success, though yes... I'm not sure what kind of success...

Will test this now

from xhook.

You're right, any response will fire load

from xhook.

just pushed this into xdomain, give it a try and let me know if its still not working

from xhook.