xatlas::PackCharts crash about xatlas HOT 6 CLOSED

I fixed the assert that was supposed to catch this case (chart not fitting in the atlas). bestAtlasReslotution needs + 2 for padding since one of the charts takes up the full atlas width.

from xatlas.

I fixed the assert that was supposed to catch this case (chart not fitting in the atlas). bestAtlasReslotution needs + 2 for padding since one of the charts takes up the full atlas width.

Thanks, that helped. In some cases, I had to increase the size by 100 because it kept crashing. Instead of assertation, can we use enums? #29

from xatlas.

In some cases, I had to increase the size by 100 because it kept crashing.

That shouldn't happen. Do you have a model I can use to reproduce that?

Also, if all you need is atlas dimensions to be divisible by 4, it's not necessary to pack charts again. Instead, divide by the dimensions you want when normalizing texture coordinates here.

from xatlas.

That shouldn't happen. Do you have a model I can use to reproduce that?

It's fixed in the latest version. Thank you.

Also, if all you need is atlas dimensions to be divisible by 4, it's not necessary to pack charts again.

I can, but I'm packing again to check if the new atlas size is generating more than one atlas, if it is, then I increase the resolution to get a single atlas.

Btw, I found a new crash. I have around 14000 models, and xatlas crashes on 5 models. Here's one of them:

LowLODModel.zip

Just do example_repack.exe clump_output.obj, and you'll see the crash.

from xatlas.

Nice, it's fixed now except for one model: freeway6_lan2.zip
This one seems to crash on xatlas::PackCharts.

from xatlas.

I didn't check the newer commits. Everything's working now. Thanks a lot.

from xatlas.