Git Product home page Git Product logo

Comments (8)

lieff avatar lieff commented on May 24, 2024 1

Im using Ubuntu 18.04. With VK_IMAGE_TILING_OPTIMAL I get following:
screenshot from 2018-08-03 19-53-02

from vkvg.

tokyovigilante avatar tokyovigilante commented on May 24, 2024 1

from vkvg.

jpbruyere avatar jpbruyere commented on May 24, 2024

Depending on your hardware, this combination doesn't seem to be accepted. I have let the tiling of the single sampled backend texture to linear to be able to load bitmap with few operations. I'll consider setting it to optimal (better for performances) and modify my bitmap loading.
Maybe I'll have also to test more precisely the accepted combinations of options (which vary among hardwares).
The validation error comes from the source uniform (Sampler2D) used in the main shader which is used only for surface painting, when painting with solid color or gradient, it's not binded. The options to solve this is either bind a dummy texture when source is unused or duplicate the main shader (but it would duplicate also the pipelines).
Thanks for your report.

from vkvg.

lieff avatar lieff commented on May 24, 2024

Hardware: Nvidia GTX 980, driver v390.48

from vkvg.

jpbruyere avatar jpbruyere commented on May 24, 2024

After several tests with Optimal tiling for the single sample backend img, the conclusion is that there is some other reasons for me to have kept it in linear tiling. (In fact, I had already implemented loading and saving with staging buffers)
Copy operations with optimal tiling has some constrains tied to what's called image transfer granularity, that causes on screen output and saving to png to fail with certain surface dimensions. Using square sizing and power of 2 dimensions ensure success, but vkvg should be able to handle random sizing for surfaces.
I've tried also to test vkGetPhysicalDeviceImageFormatProperties2 but it sigsev, I'll test with other drivers and gpu.
What is your OS? is it windows? Did you get something on screen when running test? if not, try engine and surface size to 512x512 and Optimal tiling.
I'll try to test what could be achieve with transfer granularity...

from vkvg.

tokyovigilante avatar tokyovigilante commented on May 24, 2024

Using VK_IMAGE_TILING_LINEAR fails on MoltenVK on macOS too. Works fine with VK_IMAGE_TILING_OPTIMAL . Is there any reason not to use VK_IMAGE_TILING_OPTIMAL always?

from vkvg.

jpbruyere avatar jpbruyere commented on May 24, 2024

I should add a complete supported image format check at device creation. It depends on hardware and driver implementation.
VK_IMAGE_TILING_OPTIMAL add sometimes some texture size constraints, and vkvg surface should be able to handle any size.

from vkvg.

jpbruyere avatar jpbruyere commented on May 24, 2024

Dynamic selection of tiling has been implemented, don't hesitate to give feedback.

from vkvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.