Feature request: Return truncated rows from encoded_text instead of raising an error about vesta HOT 6 CLOSED

That looks great to me @jparise!

from vesta.

@jparise it worked exactly like I expected it to for my use case! Thanks again!

from vesta.

The sounds like a useful change.

I might implement it by adding a new max_rows argument (which could be None for no maximum), but I'll also think about whether it's ever helpful to raise that row-related ValueError instead of just passing that responsibility on to the caller (by returning as many rows as were needed).

from vesta.

Thanks! That would be most helpful indeed!

from vesta.

@natekspencer #115 implements the max_rows approach and drops the ValueError. How does that look to you?

from vesta.

@natekspencer Great! I just merged it to main. If you're able to test it out, let me know if you have any feedback before I tag a new release.

from vesta.