Git Product home page Git Product logo

Comments (3)

jpahullo avatar jpahullo commented on September 4, 2024

Thanks for the reporting @leonstr .

This is unitentional. Deleted users should not be listed. Any of the other users must be listed. Imagine you merge 2 users in the inverse order. So, proceeding with the inverse merging operation should leave things as they should initially. So, for this reason, only suspended and non suspended users must be listed.

If you believe you can report a patch to solve this, it would be easier and quicker to get solved. Otherwise, we get it recorded to address it when we have availability.

Thanks a lot in advance,

Jordi

from moodle-tool_mergeusers.

leonstr avatar leonstr commented on September 4, 2024

@jpahullo The commit for the PR to fix #275 is built upon the commit to fix this issue as 1) they're directly related, and 2) they both touch the same code. I hope these two changes are not confusing!

from moodle-tool_mergeusers.

jpahullo avatar jpahullo commented on September 4, 2024

Ok about your above comment. Thanks a lot for working on it!

Please, close the PR that finally is not useful by now by your own, so I finally do not get confused in the future.

Let me know analyse the PR #276 then.

Thanks again.

Jordi

from moodle-tool_mergeusers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.