Git Product home page Git Product logo

Comments (8)

blrhc avatar blrhc commented on September 26, 2024 1

@maciejmatu

from joystream-org.

maciejmatu avatar maciejmatu commented on September 26, 2024

@bedeho @blrhc
Regarding issue 3:
After merging Rome page, the analytics section is between two Testnet items. Should I do anything here, or should we consider it fixed?

image

Regarding issue 4:
This is what it would look like with enlarged images. If we break to 3 items per row then I we will be able to make it as big as on the design, but with 4 items, we'll get text-breaking (the biggest problem is the long "Not Running" text, that breaks to a newline). But if what's on the screenshot is fine I will update it this way.

image

from joystream-org.

bedeho avatar bedeho commented on September 26, 2024

Regarding issue 3:
Yes that helps, but actually, could yous till try, because there will be times where there is no new network announced, e.g. in some time window after Rome is deployed.

Regarding issue 4:
No wrapping is acceptable, it severly degrades ledgibiilty. I see now in the design this is not dealt with as well as I remember. This should be addressable by simply affording greater horizontal space for the text label container. This means the horizontal space required for each unit will probably increase, and thus the minimum horizontal width at which the container can hold the full 4 units will also increase, but that is not a problem. Also shortening some of the labels could make sense, do you think you could come up with slightly more succinct versions for some of them? e.g. "Active Storage Providers" => "Storage Providers"

from joystream-org.

maciejmatu avatar maciejmatu commented on September 26, 2024

Regarding issue 3:
I added a title property, so when needed you can add it. Is this what you had in mind?
image

Regarding issue 4:
I changed the block max-width, and shortened the titles. If needed I can make it even bigger. On the screenshot this is what it looks like on ~1500px with. On the smallest breakpoint the only word that breaks to a newline is Not Running
image

from joystream-org.

blrhc avatar blrhc commented on September 26, 2024

@bedeho

from joystream-org.

bedeho avatar bedeho commented on September 26, 2024

Yes exactly, seems to work reasonably. Icon size is still same as before though, right?

from joystream-org.

maciejmatu avatar maciejmatu commented on September 26, 2024

@bedeho I made them ~15% larger. Here is the comparison on 1400px. Top is before, bottom is after
image

from joystream-org.

bedeho avatar bedeho commented on September 26, 2024

Great job, thanks for the clear comparison.

from joystream-org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.