Git Product home page Git Product logo

Comments (4)

thomascube avatar thomascube commented on September 23, 2024 1

Thanks for the fast fix! I can confirm that the problem is resolved with 0.14.1.

from kubedock.

joyrex2001 avatar joyrex2001 commented on September 23, 2024

This seems like a comeback of #40. The Lease resource is again left with a non-empty holderIdentity field after kubedock terminates.

Starting fails with timeout acquiring lock right, and you do see exit signal recieved, removing pods, configmaps and services when kubedock stops?

It looks indeed like #40 is back.

from kubedock.

joyrex2001 avatar joyrex2001 commented on September 23, 2024

In #40 I did not found the root-cause, but re-organizing and rewriting the exit handler worked around it. Moving towards go 1.21 re-introduced the bug.

The root-cause is that the main go-routine is killed before the exit handler was finished, which would crash the exit handler. Making the main go-routine wait indefinitely and moving the exit responsibility to the exit handler (which was the initial imlementation/idea), makes sure all cancelations (including the release lock) are executed.

from kubedock.

joyrex2001 avatar joyrex2001 commented on September 23, 2024

Released https://github.com/joyrex2001/kubedock/releases/tag/0.14.1 with this fix.

from kubedock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.