Git Product home page Git Product logo

Comments (7)

andreezy777 avatar andreezy777 commented on July 19, 2024

@joyrex2001 Hi.
As I understand, to pass label, for example com.joyrex2001.kubedock.request-memory to kafka container we should do it through the code using withLabel method in testcontainers.
So, we need to update all our services which takes a lot of time.

If I'm correct above, then +1 for this topic, it would be great to be able to pass labels through env vars.

from kubedock.

joyrex2001 avatar joyrex2001 commented on July 19, 2024

@andreezy777 if you want to set kubedock specific controls, like com.joyrex2001.kubedock.request-memory, these usually already have an environment variable alternative available. Unfortunately not (that well) documented. In you example it would be K8S_REQUEST_MEMORY (see here).

from kubedock.

andreezy777 avatar andreezy777 commented on July 19, 2024

@andreezy777 if you want to set kubedock specific controls, like com.joyrex2001.kubedock.request-memory, these usually already have an environment variable alternative available. Unfortunately not (that well) documented. In you example it would be K8S_REQUEST_MEMORY (see here).

As I read in readme there are some differences between env kubedock.request-memory and label com.joyrex2001.kubedock.request-memory. Because first one - it’s about global limits and second one about limits specially for needed container.

Pls, confirm that “global” means that every container that will started by kubedock will have limits that was set up by env var , but if I need, for example apply limits X for postgres container and limits Y for Kafka container, then I need to use label through code, right?

from kubedock.

joyrex2001 avatar joyrex2001 commented on July 19, 2024

@andreezy777 correct, the one you would set when starting kubedock (via env, or cli argument) will be applied to all created containers. If a container adds a label itself, that will take precedence over this default.

from kubedock.

joyrex2001 avatar joyrex2001 commented on July 19, 2024

In 7d823ee I added support for adding labels and annotations that need to be propagated to the kubernetes pods. This can be done via cli --label and --annotation as well via adding environment variables that start with K8S_LABEL_ and K8S_ANNOTATION_.

from kubedock.

seboudry avatar seboudry commented on July 19, 2024

Awesome 🤩

When do you plan a new release?

from kubedock.

joyrex2001 avatar joyrex2001 commented on July 19, 2024

Just released https://github.com/joyrex2001/kubedock/releases/tag/0.14.0 with this feature.

from kubedock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.