Comments (7)
Then there needs to be a way to gracefully shutdown echo_server.
from libuv.
not necessarily- you can use the process_wait with a small timeout on each of the helpers after the main process exits. if process_wait has not timed out then kill the helper and assume everything is fine.
from libuv.
sorry - above was accidentally pushed. it's not in the history any longer
from libuv.
something like this https://gist.github.com/925116 would catch crash errors from echo_server
from libuv.
Looks good.
- should we change process_wait to not take a vector? We're not using it anyway.
- Is the race condition intentional? During
if (timeout) {terminate(); wait();}
the process can still exit gracefully. But if that happens the timeouts in are probably wrong, so it's good that ASSERT(result != 0); fails.
from libuv.
let's keep the vector. i'll land this once i figure out how to wait with timeouts in unix - it's not so easy.
from libuv.
Closing old stalled issues, please reopen at https://github.com/libuv/libuv if still needed.
from libuv.
Related Issues (20)
- src/win/fs.c have not ANSI character, generate warning C4819. HOT 2
- socks server sample - conn structure bug HOT 2
- handle->write_queue_size >= req->queued_bytes HOT 4
- Invalid write when closing process handle after 1.0.0-rc1 HOT 7
- File system events stop working after file editing with vim HOT 1
- threadpool: add an runtime API analogous to UV_THREADPOOL_SIZE HOT 3
- v0.10: tests don't compile on Windows HOT 2
- libuv 1.0.0: tests fail if ipv6 is missing HOT 2
- Put back dtrace probes HOT 1
- libuv-1.0.0-stable fail in uv_winsock_init HOT 1
- On assertion failling (Darwin Kernel Version 14.0.0) HOT 1
- Creation of full duplex pipe via spawn causes deadlock on Windows. HOT 2
- Utilize lock-free queue for worker thread pool HOT 3
- OSX 10.10.2 issues. HOT 1
- Can i use libuv in IOS project? HOT 1
- -
- make error : make: *** [libuv.la] Error 1 HOT 1
- can uv_timer_start be called multiple times? HOT 1
- make check "check-am" failing
- Accidentally created. Sorry!
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libuv.