Enhancement: ModelView.find_all and ModelView.count still don't take into account the Request for the stmt - needed for multitenant support about starlette-admin HOT 5 OPEN

How about we wrap the calls to get_list_query and get_count functions inside a try-catch block? In the try block, we can pass the request and to maintain backward compatibility, we will catch the Too Many Arguments error and call the functions without the request, but with a deprecation warning.

from starlette-admin.

I once was in a talk by a famous software developer and he was covering a DO/DONT list. In the DONT list, was the usage of exceptions as a control flow mechanism. So, I never do.

To be honest, I prefer my solution because there is no magic involved, it is bread&butter OO, and backwards-compatible. And very K.I.S.S.

You can put the deprecation warnings in the 2 new methods in views.py.ModelView

But either way, I am looking forward to having this, thank you SO MUCH for listening! Super happy here.

from starlette-admin.

In the DONT list, was the usage of exceptions as a control flow mechanism.

I agree with you, but adding those two methods may cause confusion. Instead, we can introduce a breaking change in release 0.14.

from starlette-admin.

thank you SO MUCH for listening! Super happy here.

Thank you for your kind words. I'm glad to know that you are enjoying being here.

from starlette-admin.

I agree with the OP, the first suggestion seems better, and very much needed for this kind of filter.

from starlette-admin.