Git Product home page Git Product logo

Comments (2)

jowilf avatar jowilf commented on May 18, 2024

def can_delete(self, request: Request) -> bool:

It is a synchronous method and can not be awaited

Refer to https://github.com/jowilf/starlette-admin-demo/blob/main/app/sqla/views.py for usage example

from starlette-admin.

dolamroth avatar dolamroth commented on May 18, 2024

I see, my bad.

At first, I wanted to suggest to remake methods into async, since one can potentially access AsyncSession from request in those methods.

But then I saw that those methods are used as templatetags, and starlette disencourages to use async logic in template rendering https://www.starlette.io/templates/#asynchronous-template-rendering

Thank you for your time 👍

from starlette-admin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.