0.6.0 broke Vite dev mode about jotai-devtools HOT 26 CLOSED

Hey @maylortaylor, just to clarify further, this issue does not completely block you from using DevTools. DevTools does not rely on the code that's causing this error 😁

Here is a workaround you may use in your project. Define process.platform in your vite.config.ts file until the PR with the fix is merged.

export default defineConfig({
  // ...
  define: {
    'process.platform': '' // you may set this to anything
  }
})

Thanks so much @arjunvegda! I set 'process.platform': null and it started working just fine.
One question though, is there a way move the Jotai Devtools icon or is there a plan to make a chrome extension in the future? The icon is covering some of my UI that I need.

I would also suggest adding a new prop on the Devtools that would set it's placement (top-right, bottom-left, etc)

from jotai-devtools.

also running into this issue.

by sheer coincidence, last week we needed to build json diff/patching into our project. we ran into issues with jsondiffpatch for exactly this reason, and instead moved to fast-json-patch, which is a much cleaner and more modern API. it's typescript-native. might be worth considering!

from jotai-devtools.

Hey @maylortaylor, just to clarify further, this issue does not completely block you from using DevTools. DevTools does not rely on the code that's causing this error 😁

Here is a workaround you may use in your project. Define process.platform in your vite.config.ts file until the PR with the fix is merged.

export default defineConfig({
  // ...
  define: {
    'process.platform': '' // you may set this to anything
  }
})

Just an fyi, this doesn't work with Vitest because then Vitest can't set process.env while testing. On top of that vite-plugin-node-polyfills causes a lot of terminal output while transforming. So the only way is patching for me atleast.

Edit: There's actually an even better way to do this, which is overriding packages. Add the following in your package.json. I had to do a clean install after for it to work.
NPM:

  "overrides": {
    "jotai-devtools": {
      "chalk": "^4.1.2"
    }
  }

Yarn:

  "resolutions": {
    "jotai-devtools/**/chalk": "^4.1.2"
  }

PNPM:

  "pnpm": {
    "overrides": {
      "jotai-devtools>chalk": "^4.1.2"
    }
  }

Note: I've only tested with NPM.

from jotai-devtools.

vite-plugin-node-polyfills helped

from jotai-devtools.

Perhaps we could use benjamine/jsondiffpatch#315 (comment) until a long-term fix is identified. 🤔 I'll try to brainstorm other ideas.

I tried this! Unfortunately, the build fails due to some import error.

I created a PR that should fix this on the jsondiffpatch repo 🤞

from jotai-devtools.

Hey @maylortaylor, just to clarify further, this issue does not completely block you from using DevTools. DevTools does not rely on the code that's causing this error 😁

Here is a workaround you may use in your project. Define process.platform in your vite.config.ts file until the PR with the fix is merged.

export default defineConfig({
  // ...
  define: {
    'process.platform': '' // you may set this to anything
  }
})

from jotai-devtools.

Great suggestions! @maylortaylor. Let's continue this discussion in #86

from jotai-devtools.

Wouldn't it be safer to wrap <DevTools/> with a process.env.NODE_ENV === 'development' check then? 🤔

Jotai Devtools isn't part of any test code but the define block applies to all environments (including Vitest).

export default defineConfig({
  // ...
  define: {
    'process.platform': '' // you may set this to anything
  }
})

This define block will make process.platform readonly (probably by setting it to a const) and Vitest needs to be able to set process.platform to run. So it's not actually an issue with the library, just the workaround.

from jotai-devtools.

Fix released in v0.6.2 🚀

from jotai-devtools.

The import of chalk seems to come from jsondiffpatch:

I had to disable javascript source maps to really see this

from jotai-devtools.

The problematic import seems to be here:

jsondiffpatch has a static import of chalk which causes the crash

from jotai-devtools.

Maybe polyfilling the process node module can help, I will try.

Not sure if other bundlers will have similar problems.

from jotai-devtools.

Thanks for reaching out and for the investigation! It's super helpful

I'm currently away from keyboard for a week, I'll look into this in detail sometime next week.

Meanwhile, is this happening only with Vite? Or are we seeing issues with Rollup and other bundlers too?

from jotai-devtools.

This issue is logged on their repo too. There are a few workarounds you may look into btw.

for exactly this reason, and instead moved to fast-json-patch, which is a much cleaner and more modern API.

Thanks for the recommendation. fast-json-patch looks good, I like that it follows the RFC 6902 standard. Would you be open to creating a PR?

from jotai-devtools.

i did try to give it a shot, but for some reason when I use the local version of jotai-devtools, it's missing all the atoms...

any tips on getting jotai-devtools to work locally?

what I did was:

pnpm install
pnpm compile

and then I referenced it in my project's package.json like:

"jotai-devtools": "../jotai-devtools"

I should note that version 0.5.3 from npm works fine, and even version 0.6.0 works fine via npm, using the polyfill plugin that gunters63 mentioned.

from jotai-devtools.

Ah sorry, for the lack of a contribution guide 😅. We use storybook to develop this extension.

Here are steps to get you up and running locally

• pnpm install
• pnpm storybook
• Use DevTools.stories.tsx as a playground or Playground.stories.tsx to test your changes

from jotai-devtools.

so, i did a bit more digging here. tl;dr i don't think we should use fast-json-patch, and instead should just ship a trivial patch to jsondiffpatch's chalk dependency to get it to play nice with vite (i.e. not reference process).

I've created a PR #85 which implements this patch using pnpm.

I can confirm that my patch at least prevents jotai-devtools from from totally breaking vite, but I can't actually test the functionality because I still get that issue where all the atoms are missing when I install via npm link jotai-devtools. I can confirm that it does work locally via pnpm storybook, and it passes all the tests.

More context:
RFC 6902 does not include the previous values in the delta operations it generates. this doesn't matter for what I need it for in my project, but now that i've dug into how JSON diffing is being used in this project, it's basically the whole point, making the package of little value (unless you want to forego the entire "diff" view feature, which I don't think you do).

Besides that, looking at the code, it's very tightly coupled to the diff format produced by jsondiffpatch. there's a lot of elaborate string and object manipulation code, all with any types (since jsondiffpatch doesn't include types)... so even if we found an alternative json diff library, unless it happens to output in the same non-standard format as jsondiffpatch... it would be a big undertaking to rework everything to use the new format.

Given that... I think the best option is simply using jsondiffpatch and patching it to avoid the process call. Turns out that's a trivial one-line patch, as someone pointed out here.

from jotai-devtools.

Thanks for your investigation and PR!

I'm not very confident in shipping a patch via jotai-devtools 😅 given that our users have multiple workarounds (define process.platform on their end, patch jsondiffpatch on userland, etc.). Besides, based on your patch I wonder if it would work for non-pnpm package managers 🤔

Perhaps, you may be interested in creating a PR in the jsondiffpatch repo for this issue 😄

I can't actually test the functionality because I still get that issue where all the atoms are missing when I install via npm link jotai-devtools.

We have a canary deployment setup for PRs, here are the instructions on how to install the canary version generated using your PR.

from jotai-devtools.

agreed with you! the pnpm patching system was new to me too — i tried the canary package and it fails with the same chalk/process issue, so looks like the pnpm patch isn't coming through.

I do feel that this is something that should be fixed in jotai-devtools, or at the very least documented, since ultimately jotai-devtools is bundling a dependency with a show-stopping bug in it for vite users.

i agree that the ideal outcome is jsondiffpatch fixes this, but it seems that package has been abandoned since 2021, so I think a PR will fall on deaf ears :(

from jotai-devtools.

Yes, ideally it'd be nice to address it in jotai-devtools. Perhaps we could use jsondiffpatch-rc until a long-term fix is identified. 🤔 I'll try to brainstorm other ideas.

but it seems that package has been abandoned since 2021

The author of the jsondiffpatch library is open to having a volunteer. Perhaps there is a beam of hope 😅 .

Chalk dropped the process check in chalk@>=3.0.0, so maybe the PR would be slightly less complex. WDYT?

from jotai-devtools.

Writing here to say that I also am experiencing this issue. I really hope that PR for jsondiffpatch goes through and is a solution to this. Would really love to use the DevTools soon!

My project's setup is

• react 18.2.0
• jotai 2.2.2
• jotai-devtools 0.6.0
• vite 4.3.9

from jotai-devtools.

.

I choose to use version 0.5.3

from jotai-devtools.

@Xenfo Thanks for sharing your solution! 🙏

Out of curiosity, why do we need Jotai DevTools when running tests? 🤔

from jotai-devtools.

We don't but the define block in the Vite config overrides process.platform for all environments, meaning it'll override it when testing with Vitest which causes it to crash and fail.

from jotai-devtools.

Wouldn't it be safer to wrap <DevTools/> with a process.env.NODE_ENV === 'development' check then? 🤔

from jotai-devtools.

Edit: There's actually an even better way to do this, which is overriding packages. Add the following in your package.json. I had to do a clean install after for it to work.

this worked a charm! for me, using pnpm, what I had to do was:

"pnpm": {
  "overrides": {
    "jsondiffpatch>chalk": "^4.1.2"
  }
}

from jotai-devtools.