Comments (9)
Also, thank you for opening an issue first!
from react-images.
@RobinTail Good idea, that could be useful.
Perhaps we could make it more generic though, like an array of elements to render in the top bar. That way consumers can add whatever functionality and style they want.
Thoughts?
from react-images.
Nice idea, @jossmac ^_^
Then I can add a new prop to Lightbox
like this:
customControls: PropTypes.arrayOf(PropTypes.node),
There also will be some changes to renderCloseButton()
method and minor style fix to .closeButton
class.
Do you agree?
from react-images.
Sounds good to me. Looking forward to your PR
from react-images.
I think placement at the bottom left would be more appropriate.. perhaps just before the photo count. Similar the way most "lightboxes" are arranged like Flickr and Facebook.
from react-images.
from react-images.
@jossmac, after releasing version 0.4.7, i do not see my new feature in build file https://github.com/jossmac/react-images/blob/master/lib/Lightbox.js . There is no new prop .customControls
from react-images.
@RobinTail this is sorted now, right?
from react-images.
@jossmac Yes, thank you for updating build files :)
from react-images.
Related Issues (20)
- showNavigationOnTouchDevice is not part of the type for CarouselProps HOT 2
- Style Autoprefixer broken for `display: flex`
- TypeError: undefined is not an object (evaluating 'currentView.caption') HOT 1
- Option to always show header and footer. HOT 1
- Warning using ModalGateway in react's Strict Mode HOT 2
- Is there a way to disable some/all the shortcuts ? HOT 1
- Component Customization with Styled-Components Library HOT 5
- Picture title HOT 4
- NPM Audit Security report HOT 3
- 想添加一个查看预览图时,可旋转的功能
- React 17 support HOT 6
- FATAL: 1.1.7 to 1.2.0-beta.6 breaks fullscreen mode ('active' of undefined) HOT 7
- is there a way we can disable scrolling for the carousel
- Demo error HOT 4
- In search of a replacement ❓ HOT 2
- Can I get the images data from a json file and how? Thanks HOT 1
- Can you add an option for adding hyperlink(s) under the photo? HOT 1
- A vulnerability introduced in react-images HOT 2
- Can it view .tif or .tiff type image ? HOT 1
- Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes'. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-images.