Git Product home page Git Product logo

Comments (9)

jossmac avatar jossmac commented on July 21, 2024 1

Also, thank you for opening an issue first!

from react-images.

jossmac avatar jossmac commented on July 21, 2024

@RobinTail Good idea, that could be useful.

Perhaps we could make it more generic though, like an array of elements to render in the top bar. That way consumers can add whatever functionality and style they want.

Thoughts?

from react-images.

RobinTail avatar RobinTail commented on July 21, 2024

Nice idea, @jossmac ^_^
Then I can add a new prop to Lightbox like this:
customControls: PropTypes.arrayOf(PropTypes.node),

There also will be some changes to renderCloseButton() method and minor style fix to .closeButton class.

Do you agree?

2016-06-23_16-33-58

from react-images.

jossmac avatar jossmac commented on July 21, 2024

Sounds good to me. Looking forward to your PR

from react-images.

neptunian avatar neptunian commented on July 21, 2024

I think placement at the bottom left would be more appropriate.. perhaps just before the photo count. Similar the way most "lightboxes" are arranged like Flickr and Facebook.

from react-images.

RobinTail avatar RobinTail commented on July 21, 2024

@jossmac PR: #60

from react-images.

RobinTail avatar RobinTail commented on July 21, 2024

@jossmac, after releasing version 0.4.7, i do not see my new feature in build file https://github.com/jossmac/react-images/blob/master/lib/Lightbox.js . There is no new prop .customControls

from react-images.

jossmac avatar jossmac commented on July 21, 2024

@RobinTail this is sorted now, right?

from react-images.

RobinTail avatar RobinTail commented on July 21, 2024

@jossmac Yes, thank you for updating build files :)

from react-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.