Git Product home page Git Product logo

Comments (9)

jossmac avatar jossmac commented on July 21, 2024 2

After some tinkering over the weekend 0.4.3 should cover everyone's needs. Thank you all for being patient.

Please try again and let me know how you go :)

from react-images.

jossmac avatar jossmac commented on July 21, 2024 1

Might be time for an update. I'll try and fit it in this week.

Thank you both for creating/commenting issues, I really appreciate it. Otherwise this stuff flies under the radar for too long.

from react-images.

jossmac avatar jossmac commented on July 21, 2024 1

@Flyr1Q @kachkaev @Laurentvw @jjordy @becarlos

I've release v0.4.1 with updated dependencies.

Please get latest and let me know if this resolves your issues.

from react-images.

kachkaev avatar kachkaev commented on July 21, 2024

Same issue here with React 15.0.2 – thanks for the workaround @Flyr1Q!

The lightbox started working after I manually deleted /node_modules/react-images/node_modules/react & /node_modules/react-images/node_modules/react-dom. Should be fine while I'm playing with the project alone, but obviously this is something worth fixing.

from react-images.

sqrtsanta avatar sqrtsanta commented on July 21, 2024

@jossmac I've just tried it, the warning still appears and gallery does not open. May be I have to reinstall node_modules or clean cache? Will wait for @kachkaev response :)

from react-images.

kachkaev avatar kachkaev commented on July 21, 2024

@Flyr1Q I did not experiment a lot, just ran the following and re-launched the app:

npm remove --save react-images
npm install --save react-images

(did this just in case instead of a normal update because I manually tweaked npm_modules/react-images/* previously)

No errors showed up in the console when I clicked on a couple of images. Which ones do you see?

from react-images.

jjordy avatar jjordy commented on July 21, 2024

Im out of town for the weekend but I will upgrade when I get back and let you know the results. @jossmac Yo da man!

from react-images.

Laurentvw avatar Laurentvw commented on July 21, 2024

I did what @kachkaev said and I'm still getting an error.

Here's the log after the install:

└─┬ [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  ├─┬ [email protected]
  │ └── [email protected]
  ├── UNMET PEER DEPENDENCY [email protected]
  ├── [email protected]
  ├── [email protected]
  ├── [email protected]
  └── [email protected]

My package.json has "react": "^15.0.0".

The error in question when clicking an image:
invariant.js:38 Uncaught Invariant Violation: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component'srendermethod, or you have multiple copies of React loaded (details: https://fb.me/react-refs-must-have-owner).

I think the react dependencies of react-images need to be less strict:

"react": "^15.0.2",
"react-addons-transition-group": "^15.0.2",
"react-dom": "^15.0.2",

Maybe instead of ^15.0.2 it should be set to >=0.14?

from react-images.

sqrtsanta avatar sqrtsanta commented on July 21, 2024

@jossmac Yeah, everything is working now. Thanks @JedWatson @jossmac

from react-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.