Comments (8)
Last time I looked into srcset
the browser coverage was really poor, though it seems to have improved http://caniuse.com/#feat=srcset
I think it would be great to support it. Would you be interested in submitting a PR?
from react-images.
@jossmac Great! I'll work on a PR. Since browsers that don't support it will just use src, it should be harmless.
from react-images.
@neptunian sounds good, I look forward to it
from react-images.
@jossmac Can I introduce some other kind of image placeholder tool rather than the fillmurray.com one? With srcset I'll need to grab various sizes of the same image which fillmurray.com doesn't seem to support. This website does however: http://lorempixel.com/ Or if you have any suggestions...
Also, I notice the thumbnails are simply larger photos being squashed down, so could update that, if desired, as well.
from react-images.
@neptunian LoremPixel is a terrific service, can't wait to see the images you choose!
Good call on the thumbnails, i was pretty rushed when releasing the demo site, thanks mate :)
from react-images.
Resolved by #6
from react-images.
@jossmac I hadn't updated the documentation yet in my branch that was merged. Shall I do that?
from react-images.
@neptunian sorry! Would you mind submitting a separate PR with docs?
from react-images.
Related Issues (20)
- showNavigationOnTouchDevice is not part of the type for CarouselProps HOT 2
- Style Autoprefixer broken for `display: flex`
- TypeError: undefined is not an object (evaluating 'currentView.caption') HOT 1
- Option to always show header and footer. HOT 1
- Warning using ModalGateway in react's Strict Mode HOT 2
- Is there a way to disable some/all the shortcuts ? HOT 1
- Component Customization with Styled-Components Library HOT 5
- Picture title HOT 4
- NPM Audit Security report HOT 3
- 想添加一个查看预览图时,可旋转的功能
- React 17 support HOT 6
- FATAL: 1.1.7 to 1.2.0-beta.6 breaks fullscreen mode ('active' of undefined) HOT 7
- is there a way we can disable scrolling for the carousel
- Demo error HOT 4
- In search of a replacement ❓ HOT 2
- Can I get the images data from a json file and how? Thanks HOT 1
- Can you add an option for adding hyperlink(s) under the photo? HOT 1
- A vulnerability introduced in react-images HOT 2
- Can it view .tif or .tiff type image ? HOT 1
- Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes'. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-images.