Git Product home page Git Product logo

Comments (8)

jossmac avatar jossmac commented on August 22, 2024

Last time I looked into srcset the browser coverage was really poor, though it seems to have improved http://caniuse.com/#feat=srcset

I think it would be great to support it. Would you be interested in submitting a PR?

from react-images.

neptunian avatar neptunian commented on August 22, 2024

@jossmac Great! I'll work on a PR. Since browsers that don't support it will just use src, it should be harmless.

from react-images.

jossmac avatar jossmac commented on August 22, 2024

@neptunian sounds good, I look forward to it

from react-images.

neptunian avatar neptunian commented on August 22, 2024

@jossmac Can I introduce some other kind of image placeholder tool rather than the fillmurray.com one? With srcset I'll need to grab various sizes of the same image which fillmurray.com doesn't seem to support. This website does however: http://lorempixel.com/ Or if you have any suggestions...

Also, I notice the thumbnails are simply larger photos being squashed down, so could update that, if desired, as well.

from react-images.

jossmac avatar jossmac commented on August 22, 2024

@neptunian LoremPixel is a terrific service, can't wait to see the images you choose!

Good call on the thumbnails, i was pretty rushed when releasing the demo site, thanks mate :)

from react-images.

jossmac avatar jossmac commented on August 22, 2024

Resolved by #6

from react-images.

neptunian avatar neptunian commented on August 22, 2024

@jossmac I hadn't updated the documentation yet in my branch that was merged. Shall I do that?

from react-images.

jossmac avatar jossmac commented on August 22, 2024

@neptunian sorry! Would you mind submitting a separate PR with docs?

from react-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.