Git Product home page Git Product logo

Comments (8)

JosephHewitt avatar JosephHewitt commented on August 9, 2024 1

I looked more into this issue today. Whenever this issue occurs, Safari is waiting for a response from the wardriver which never arrives. From the perspective of the wardriver, Safari never actually sends a request, it simply opens the TCP connection and leaves it idle; this means the wardriver never sends a reply and the connection stays idle from both sides until timeout.

I have implemented a short timeout in #58 which closes the TCP connection after 750ms if no data is sent by the client. This prompts Safari to re-open the connection and try again. I have only tested this on iOS and it seems to work well.

While I did not find the root cause of this, the problem now seems to be resolved. Since the issue was happening at a lower level than HTTP, the closing HTML tags made no change. If I ever refactor the HTML, I will properly open/close all relevant tags, but for now I will leave the HTML as-is since that part of the code is messy and hard to maintain.

I will make a new beta release shortly which will include this change. I will also leave the issue open for a while in case there are any issues with this fix.

Thank you for opening this issue.

from wardriver_rev3.

JosephHewitt avatar JosephHewitt commented on August 9, 2024

Hi,

Thanks for letting me know about this, the missing tags were not intentional so I will add them soon.

If it is only the main page (with the list of files to download) that is slow, you are probably seeing the affects of issue #2 where it loads slower as more files are saved.

from wardriver_rev3.

pejacoby avatar pejacoby commented on August 9, 2024

I should have been more specific- the slowness is between the time I tap on a file download link and when the download prompt appears on my phone. This might just be the time it takes the reader to open the file for sending. I’ll do some more timing to see if file size makes a significant difference- it doesn’t seem to.

from wardriver_rev3.

pejacoby avatar pejacoby commented on August 9, 2024

I did some further testing and the slowness appears to be a SAFARI browser issue. Both on iOS and MacOS. Regardless of the number of files on the SD card -- 30 or just 1.

If I use Firefox on MacOS to download files, results are instantaneous. Same for Chrome on MacOS.

If I use Safari on iOS, there is a consistent 28-30 second delay after tapping a download link and getting the "Save" prompt to save the file.
If I use Safari on MacOS, after clicking the download link the browser will stall and eventually the WiSpy transitions into wardrive mode and the file never downloads. During the wait, Safari shows no activity in the Network trace window.

In either Safari case, while stalled the WiSpy shows "Client connected. Awaiting request..."
Safari's Download window shows "Preparing to download"

I'll see what else I can find, but definitely seems to be a Safari thing.

from wardriver_rev3.

JosephHewitt avatar JosephHewitt commented on August 9, 2024

Hi,

Thanks for investigating this some more. I have also noticed this happening occasionally on iOS, but I am able to download the files as normal by cancelling the stalled download and trying again. For me it only happens about 5-10% of the time.

Since I was unable to reproduce this on any other device, I didn't look into it much.

I will do some tests to see if I can figure out what is happening here.

from wardriver_rev3.

pejacoby avatar pejacoby commented on August 9, 2024

Thanks for checking. I had not tried cancelling and retrying the download -- that does work every time as you noted. I'm curious to see if the HTML tag changes have any affect on Safari.
I realize I'm bleeding into another issue here, I can open a separate item if that makes more sense.

from wardriver_rev3.

pejacoby avatar pejacoby commented on August 9, 2024

I have loaded 1.1.0rc1 and it is working very well with Safari on iOS and MacOS 12.6.6. Thanks for the fix!

from wardriver_rev3.

JosephHewitt avatar JosephHewitt commented on August 9, 2024

Great, thank you for confirming.

from wardriver_rev3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.