Git Product home page Git Product logo

Comments (5)

josephg avatar josephg commented on August 22, 2024

Good idea. I think package.json will pull in nodeunit automatically, but obviously there's no npm package for the whole redis database.

from sharejs.

nornagon avatar nornagon commented on August 22, 2024

Perhaps we should make bin/sharejs use memory db by default?

from sharejs.

josephg avatar josephg commented on August 22, 2024

Yeah, maybe. Or it should try and load redis, and fall back to memory if thats missing.

from sharejs.

nornagon avatar nornagon commented on August 22, 2024

Sounds good :)

from sharejs.

josephg avatar josephg commented on August 22, 2024

The project pulls in the redis NPM package from its package.json.

Given that, the only way to check for redis availability is to try and connect to the database. If the connect fails, I don't think it makes sense to failover to a memory store - that would mean if you typed the wrong port in or something you could end up with no persistance (and somebody out there won't notice the warning messages in the log.)

I'm going to leave this as is.

from sharejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.