The method commonPath returns 0 when called with the following arguments. <div cla

json type "commonPath" about sharejs HOT 2 CLOSED

josephg commented on August 22, 2024

json type "commonPath"

from sharejs.

Comments (2)

nornagon commented on August 22, 2024

That does look like a bug (should probably check that path.length == match_path.length == common). Do you have a particular failing test case?

from sharejs.

collin commented on August 22, 2024

Ah, yes I've been able to isolate it.

This test fails with an error in test/types/json-api.coffee

'collins failing test': (test) ->
  doc = new Doc name: "name", components: []
  doc.at("name").on "insert", (p, op) ->
  doc.at("components").on "child op", (p, op) ->
  doc.emit 'remoteop', [{p:['name', 4], si:'X'}]

this is the failure I get

✖ collins failing test

Error: paths match length and have commonality, but aren't equal?
    at Object.<anonymous> (/Users/collin/Code/ShareJS/src/types/json-api.coffee:330:27)
    at Object.<anonymous> (/Users/collin/Code/ShareJS/src/types/json-api.coffee:342:14)
    at Object.emit (/Users/collin/Code/ShareJS/src/client/microevent.coffee:54:20)
    at Object.<anonymous> (/Users/collin/Code/ShareJS/test/types/json-api.coffee:346:18)
    at Object.<anonymous> (/Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/lib/core.js:233:16)
    at /Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/lib/core.js:233:16
    at Object.runTest (/Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/lib/core.js:69:9)
    at /Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/lib/core.js:115:25
    at /Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/deps/async.js:508:13
    at /Users/collin/.nvm/v0.6.6/lib/node_modules/nodeunit/deps/async.js:118:13

from sharejs.

Recommend Projects