Git Product home page Git Product logo

Comments (13)

josdemmers avatar josdemmers commented on September 3, 2024 1

Thanks for the feedback. With the current implementation it is not really possible. Because then I would need to scan for all possible affixes. That would make everything really slow.

I'm however working on a version 2 with an improved GUI. I have some ideas to handle those issues then. No promises yet when it's ready. Still a lot to do. Hope to have it ready and tested before season 2.

from diablo4companion.

josdemmers avatar josdemmers commented on September 3, 2024 1

For you maybe but not everyone learned English. I'm not going to exclude those users by saying the app no longer support languages other than English.

But let's first focus on version 2.0. When everything is ready the app should be able to support multi-line affixes without using OCR.

from diablo4companion.

meeks726 avatar meeks726 commented on September 3, 2024

A workaround I found is by screenshotting my own Affix images as .png from my actual game and replacing the ones located in the preset folder I'm using (..\Images\1080p_SMF_en\Affixes).

For example, for crit dmg, this is how I have my affixes setup in Tooltips for weapons:
image

And this is my own affix image that I captured, to somehow differentiate it from other similar affixes:
critical strike damage

(Notice the extra empty space under the actual affix to differentiate it from other similar affixes or other multi-lined affixes in general)

Unwanted crit dmg:
image

image

image

Also works for movement speed compared to SOME of the other similar movement affixes:

image

image

This works by having 'Advanced Tooltip Information' turned on in the settings so that the game adds those extra spaces(for certain affixes that would need to continue to a new line/row) between each affixes.

Unfortunately this workaround just doesn't work for damage reduction. I just ended up excluding 'damage reduction' specifically and included the other damage reductions from the active tooltips.

from diablo4companion.

imm0r avatar imm0r commented on September 3, 2024

nice idea! now i will need to make some screenshots 🗡️

from diablo4companion.

josdemmers avatar josdemmers commented on September 3, 2024

Tip to keep in mind when looking for a unique image for an affix. When capturing multiple lines the values in affixes can cause the text to have a small offset. It will no longer match in those cases.

e.g. if you have a affix with +11% or +22% it will move all text slightly to the right.

from diablo4companion.

meeks726 avatar meeks726 commented on September 3, 2024

Tip to keep in mind when looking for a unique image for an affix. When capturing multiple lines the values in affixes can cause the text to have a small offset. It will no longer match in those cases.

e.g. if you have a affix with +11% or +22% it will move all text slightly to the right.

Yeah, I came across this for 'damage reduction from affected...' I ended up uploading 2 different images of the same affix; one image is the affix with a single digit %, and the other with double digit %. The spacing for any X.X% and XX.X% each both seems to be consistent.

image

LOW damage reduction from affected by shadow dot
HIGH damage reduction from affected by shadow dot

from diablo4companion.

meeks726 avatar meeks726 commented on September 3, 2024

Is it possible for the image detecting to convert the affixes found in the Tooltip into a list of strings and have it search for affixes from a dictionary?

from diablo4companion.

meeks726 avatar meeks726 commented on September 3, 2024

I'm assuming this affects the speed and performance drastically?

from diablo4companion.

josdemmers avatar josdemmers commented on September 3, 2024

Is it possible for the image detecting to convert the affixes found in the Tooltip into a list of strings and have it search for affixes from a dictionary?

That is possible and something I'll probably look into later.
One issue is to support all 12 Diablo languages when using OCR to convert affixes to text. With image detecting it will always work for any language.

I'm assuming this affects the speed and performance drastically?

Will have to test that to be sure. But there are two steps that influence the performance:

  • The affix image to text conversion.
  • The validation part afterwards to match the text with a valid affix.

from diablo4companion.

imm0r avatar imm0r commented on September 3, 2024

One issue is to support all 12 Diablo languages when using OCR to convert affixes to text. With image detecting it will always work for any language.

Everyone can freely switch their language to whatever they want... Simply make english the main supported language and whoever wants to use Diablo4Companion needs to switch to english. This should really be no big deal.

from diablo4companion.

josdemmers avatar josdemmers commented on September 3, 2024

Closing this as v2.0 is now available.

from diablo4companion.

Larsy93 avatar Larsy93 commented on September 3, 2024

Still having this issue with Damage Reduction affixes.

from diablo4companion.

josdemmers avatar josdemmers commented on September 3, 2024

Still having this issue with Damage Reduction affixes.

@Larsy93 Could you create a new issue with some example screenshots?
Then I can probably give some tips on how to solve this with v2.0

from diablo4companion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.