MaxListenersExceededWarning with worker_threads in node.js about workerpool HOT 5 CLOSED

Thanks. Some questions/thoughts:

1. Is there a downside to just setting a higher value like 100?
2. Is this something users will want to fiddle with?
3. Can we automatically set max listeners according to the configured maxWorkers option?

from workerpool.

1. Could be harder to detect potential memory leak, although I saw similar fixes for worker implementations.
2. Possibly yes, in some cases it can narrow down the place where leak could occur.
3. Maybe, I would need to check a bit more the implementation to make sure it's feasible (e.g. are the listeners cleared/shared across the worker calls).

from workerpool.

Ok so it makes sense to have the setting configurable, like for debugging memory leaks. It would be nice if we can reuse maxWorkers for this I think, please let me know if you think that will work.

from workerpool.

Uhhh, it turned out that it's not workerpool fault and everything works as expected here (only one listener for parent and one for child thread) . The issue was with sentry initialization during job execution. Sorry!

from workerpool.

👍

from workerpool.