Git Product home page Git Product logo

Comments (17)

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

Hi @jcashby

In the link you've send I see an element bodyclass so I'm guessing there is a space missing in your header.
Please fix that part first!

Cheers, Jory

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

Hi Jory,

Thanks for the quick response. I'm not an expert coder unfortunately so not sure what you meant with the space missing in the header. This is where I have placed the code - see attachment. Sorry I didn't realise it would translate the code above.

Was there something wrong in the body element

That's the only place 'body' is on the header.php fil
Capture
e

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

Hi @jcashby

I see the issue.
Please add a space after <body (before <?php).

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

Hi, I added that in but it didn't seem to have changed anything (unless I added the space in the wrong place?).

Capture

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

I still see the same issue online, did you update the actual server file?

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

Hi, yes it updates straight away. This is also my OCS settings
Capture

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

From what I see it doesn't, I still see the element <bodyclass when I look at your site

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

I added an underscore and it's showing there but it didn't resolve the problem and I tried with a space before that.
Capture

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

I just looked again, and now it's good, with a space! :)

However, I do notice that the footer isn't loaded where it should be loaded.
At this moment it's loaded within the canvas container.

This is probably because the original theme has added <?php wp_footer(); ?> within the closing div for the st-container element.

Could you share your footer.php code?

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

That's good :) please see below for the footer

Capture

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

Hmm that looks fine oddly enough.
Not sure why the off-canvas sidebars are within the canvas container then.
What theme are you using? Is it an older one? Do they still offer support, if they do, it might be useful to ask what is hooked into the wp_footer.

You could also try to use wp_footer as the website_after hook in the plugin settings

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

Just tried adding wp_footer in (but I haven't changed anything else in the code yet unless I need too?). I use shopkeeper by themeforest. I think my support is well outdated now unfortunately.

Capture

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

Hi @jcashby

I use shopkeeper by themeforest.

Themeforest isn't the theme developer, it's the marketplace. From what I know about Themeforest you should still receive updates once you purchase a product. You should definitely update to the latest version.
Last update was in July this year:

You shouldn't need to change anything in your code if your theme is compatible. Most themes are compatible with only known issues with JavaScript (unrelated to these hooks).

If you take a look at your site's code through the element inspector of your browser you'll see that the sidebar element is within your container like so:

<div id="ocs-site" ...>
    <div id="st-container" ...></div>
    <div id="ocs-mobile-4" ...></div>
    ... other scripts and elements.
</div>

This is incorrect, it should be like this:

<div id="ocs-site" ...>
    <div id="st-container" ...></div>
</div>
<div id="ocs-mobile-4" ...></div>
... other scripts and elements.

Despite the above I also see JavaScript errors. Slidebars cannot initialize for some reason. It looks like it's an issue with your script minifier.

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

That's interesting. It did previously work for me on Shopkeeper so I'm not sure what has changed. My account has been locked from Envato as someone hacked my account and paid for some applications on there apparently so I'm just waiting to get that back before I can update the theme. I'm on Version 2.9.28. As soon as i can update my theme, I will. I'll also see what else I can do, maybe it's a third party plugin or some other settings I have?

As you say maybe I have stopped script running with Wp Rocket or something similar but I've just deactivated that plugin and it didn't seem to change anything.

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

just sent you an email on your website email listed in profile

from off-canvas-sidebars.

jcashby avatar jcashby commented on September 4, 2024

After a lot of troubleshooting. I reverted back to v0.4 and it worked! So I'm not sure whether other people are also having similar issues but it must be something in the new updates that has a conflict somewhere as the set-up in the header / footer is fine. Maybe it is a particular plugin it conflicts with but I also uninstalled pretty much every plugin first, then went through JS troubleshooting. But either way, I'll keep it at this version, thanks.

from off-canvas-sidebars.

JoryHogeveen avatar JoryHogeveen commented on September 4, 2024

as the set-up in the header / footer is fine.

Sorry but last time I checked your website the hooks setup was not fine (just checked again). It was incorrect according to the requirements of this plugin. The fact that it works with a previous version doesn't change this.

Keeping it on v0.4 is of course your own decision :) My advice is to find a correct way to implement the correct hooks in your theme (new or existing).

Closing this topic!

from off-canvas-sidebars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.