Strange behavior with RequestsAPIWrapper.head() about advocate HOT 4 CLOSED

(sorry if you already saw this, but just going to specifically ping you in case you weren't expecting anyone else to submit issues)

@JordanMilne

from advocate.

Thanks for the ping @Deimos, I took a look at the code and looks like I made a copy/paste error. When we wrap the head method in RequestsAPIWrapper we're currently doing:

        self.options = self._default_arg_wrapper(options)
        self.head = self._default_arg_wrapper(options) # wrapping options instead of `head`!
        self.post = self._default_arg_wrapper(post)

I'm guessing you're getting Insufficient information. Origin request header needed. because S3 assumes that all OPTIONS requests are for CORS preflights and is confused when it doesn't see the Origin header.

I'll patch this and push an update to PyPI this afternoon.

from advocate.

Yep, that'd definitely do it (and would explain why I was getting strange CORS-ish-sounding errors when I tried manually adding an Origin header to see what would happen).

from advocate.

This is fixed in 0.6.2 on PyPI:

In [1]: import advocate

In [2]: advocate.__version__
Out[2]: '0.6.2'

In [3]: wrapper = advocate.RequestsAPIWrapper(advocate.AddrValidator())

In [4]: wrapper.head('https://b.thumbs.redditmedia.com/6hn7cHXUEXSYh8K5ga-LCeHWBpPADv6cS6-34ty2RuE.jpg')
Out[4]: <Response [200]>

from advocate.