Git Product home page Git Product logo

Comments (10)

joostkremers avatar joostkremers commented on July 17, 2024

Could you provide a backtrace of the error? (Turn on debug-on-error and post the contents of the backtrace buffer after invoking helm-M-x.) I don't use helm so it's not easy to test for me.

from writeroom-mode.

tmalsburg avatar tmalsburg commented on July 17, 2024

Just tried a couple of things. The problem doesn't have much to do with helm specifically. It's just that helm tries to split the window horizontally (to show a list of options) and since the fringes are so wide in writeroom-mode that's not possible. Just do (split-window-right) in writeroom-mode to reproduce the problem.

You could argue that this is a feature not a bug, but if there was a way to let writeroom-mode coexist peacefully with other emacs features that want to open windows that would be fantastic. However, I'm afraid that this may require elastic fringes and that might not be easy to implement.

from writeroom-mode.

joostkremers avatar joostkremers commented on July 17, 2024

Yes, I brought up that issue on emacs-devel, but fixing it properly requires quite a bit of work and the gains would be small.

Usually, though, if a window cannot be split horizontally, Emacs will revert to splitting the window vertically, so it's never been a real problem for me. I guess you'd have to ask the helm maintainers why helm doesn't seem to do this.

from writeroom-mode.

tmalsburg avatar tmalsburg commented on July 17, 2024

Ok, I'll talk to Thierry. Thanks for the feedback.

from writeroom-mode.

joostkremers avatar joostkremers commented on July 17, 2024

I got a similar report about visual-fill-column-mode joostkremers/visual-fill-column#13, which suggests that something happened in the emacs-25 branch that causes this. I'll try and find out what's going on.

from writeroom-mode.

joostkremers avatar joostkremers commented on July 17, 2024

Do you happen to know when you last updated your Emacs sources before this problem appeared?

from writeroom-mode.

tmalsburg avatar tmalsburg commented on July 17, 2024

I can't tell because I wasn't using writeroom-mode in quite a while. Sorry.

from writeroom-mode.

joostkremers avatar joostkremers commented on July 17, 2024

The error you saw is the result of a change in behaviour when splitting windows, and it's apparently going to be included in the next Emacs release. I'll have to figure out a work-around, but I've been given some suggestions on how to do this, so hopefully I'll be able to fix this soon.

from writeroom-mode.

joostkremers avatar joostkremers commented on July 17, 2024

I'll close this issue for now. If I make any progress, I'll post about it in the visual-fill-column thread about the same issue:

joostkremers/visual-fill-column#13

from writeroom-mode.

tmalsburg avatar tmalsburg commented on July 17, 2024

I saw the discussion on emacs-devel. Thanks for the update.

from writeroom-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.