Wrong property name "RNGoogleSignIn" about react-native-google-sign-in HOT 6 CLOSED

I think it would be weird to name it otherwise as Google seems to have named it that way.

See imports at
https://github.com/joonhocho/react-native-google-sign-in/blob/master/android/src/main/java/com/reactlibrary/googlesignin/RNGoogleSignInModule.java#L28

from react-native-google-sign-in.

Actually the name of property on NativeModules is itself with the small letter "i". You can check that inside debugger, Also the properties used for color on RNGoogleSignin, i.e. dark, iconsOnly etc are also not defined when you see them in debugger. The file is:

https://github.com/joonhocho/react-native-google-sign-in/blob/master/js/GoogleSignIn.android.js#L10

from react-native-google-sign-in.

Sounds like you have had the @devfd library installed and there is some remainants of it. It has the native module named RNGoogleSignin with lowercase i. :)

from react-native-google-sign-in.

@reyhaan I am not going to change it, as changing it will break everyone else who's already using this repo. Besides, as @stami said, I am following Google SDK's naming as much as possible, so I think it's better to leave it this way.
I am sorry that you've wasted several hours, but I've put several days for this project. Closing this issue.

from react-native-google-sign-in.

@joonhocho No hard feelings, thanks for the library as I am using your version only. I didn't know that it's only me who's facing this problem.

from react-native-google-sign-in.

@reyhaan Thanks for using it.

from react-native-google-sign-in.