Git Product home page Git Product logo

Comments (4)

anibalsanchez avatar anibalsanchez commented on July 19, 2024

Hi,

No. DS must be removed from the code to follow deprecation.

The checker scans for the usage of the deprecated constants. The definition of the constant to support the newer versions of Joomla with the old source is not a case that we want to support. The deprecation of old coding practices must be followed to keep the code aligned with the modern code style.

Regards

from jedchecker.

garstud avatar garstud commented on July 19, 2024

Ok thank you for this explanation @anibalsanchez , i understand the reasons.

Do you have any good pratice about the use of DIRECTOY_SEPARATOR?
This constant name is very long and it is not easy to read code when you have a path with many DIRECTORY_SEPARATOR in it!

  • Does anyone use another short name for "DIRECTORY_SEPARATOR"?

define('DRSP', DIRECTORY_SEPARATOR);
Is this a solution that will follow the Joomla and JED coding styles?

Thank you if you can help me ;)

from jedchecker.

anibalsanchez avatar anibalsanchez commented on July 19, 2024

As far as I know, DIRECTORY_SEPARATOR is no longer necessary to define paths in modern PHP and the interpreter itself handles the differences between SOs.

from jedchecker.

garstud avatar garstud commented on July 19, 2024

Ok thank you for this info @anibalsanchez .
Indeed, I found several information about this point:
https://alanhogan.com/tips/php/directory-separator-not-necessary

from jedchecker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.